Changes, Fixes, Additions and BIG Refactoring#27
Merged
blueskythlikesclouds merged 44 commits intohedge-dev:masterfrom Feb 18, 2025
Merged
Changes, Fixes, Additions and BIG Refactoring#27blueskythlikesclouds merged 44 commits intohedge-dev:masterfrom
blueskythlikesclouds merged 44 commits intohedge-dev:masterfrom
Conversation
- Parenting now managable - Reading of data now happens in substream to ensure no reading of outside data - writer get flushed after writing node data to ensure localled node data - Fixed Node flags on write - Empty material parameters no longer receive a pointer
- All game related namespaces now placed in "Framework" namespace - All resource related files are now in the Resource namespace - Renamed Numeric to Structs and moved several toplevel files in - Several stream related files moved to IO - Updated global usings and cleaned up usings in all files
- IDirectory and IFile received doc - Filesystem made local class with singleton instance - Nullability implemented for IO and resource classes - Code reorganized - IDirectory now has an "overwrite" parameter in add/create file methods - Archive.AddFile now actually adds file to archive files - Many file checks added for error predictability
- materials can now be json serialized - mesh groups can write dependencies now - models can resolve and write dependencies now - fixed some model node semantics - added default version to lod info block and model block - fixed writing of needle archives
blueskythlikesclouds
requested changes
Feb 18, 2025
Member
blueskythlikesclouds
left a comment
blueskythlikesclouds
left a comment
There was a problem hiding this comment.
LGTM. Just noticed some typos.
blueskythlikesclouds
approved these changes
Feb 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Doing all of these commits in different pull requests would take too long and overcomplicate things, so i am sending them all at once.
Refactoring
ResourcesnamespaceIOnamespaceFrameworksnamespaceSonicTeam.DiEventvars replaced with full types for improved readability, and should be avoided in the futureAdditions
Changes
FileSystemhas been made an instance class with a staticInstanceproperty, similar to theResourceManagerclass, to allow for multiple FileSystem instances if needed.Fixes
There were many commits across these past 3 months, so these lists may be incomplete.