Skip to content

Fix NodeJsMessageStream to handle messages spanning multiple chunks #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 7, 2025
Merged

Fix NodeJsMessageStream to handle messages spanning multiple chunks #16

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ead75ea
Initial plan
Copilot Sep 6, 2025
cf93a2c
Fix NodeJsMessageStream to properly handle long messages spanning mul…
Copilot Sep 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 18 additions & 4 deletions json-rpc-node/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@ export class NodeJsMessageStream extends BaseMessageStream {
return new NodeJsMessageStream(process.stdin!, process.stdout!);
}

private buffer: string = "";

constructor(
private readonly _writeStream: NodeJS.WritableStream,
private readonly _readStream: NodeJS.ReadableStream,
Expand All @@ -32,10 +34,22 @@ export class NodeJsMessageStream extends BaseMessageStream {

this._readStream.on("data", (chunk: any) => {
const str = chunk.toString("utf8");
const parts = str.trim().split("\n"); // todo improve
for (const p of parts) {
const obj = JSON.parse(p) as Message;
this.onMessage(obj);
this.buffer += str;

// Process complete messages (terminated by newlines)
let newlineIndex: number;
while ((newlineIndex = this.buffer.indexOf("\n")) !== -1) {
const messageStr = this.buffer.substring(0, newlineIndex).trim();
this.buffer = this.buffer.substring(newlineIndex + 1);

if (messageStr.length > 0) {
try {
const obj = JSON.parse(messageStr) as Message;
this.onMessage(obj);
} catch (error) {
console.error(`Failed to parse JSON message: ${messageStr}`, error);
}
}
}
});

Expand Down