Remove legacy tag integration#17
Merged
Merged
Conversation
koertho
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the deprecated legacy tag integration from the bundle. This deletes the old
Tagnamespace, the legacyTagManagerservice, its service definitions, and the compiler pass that collected legacy tag services.The modern
HtmlHeadTagManagerpath now renders only the modern head tag objects and no longer maps or appends legacy tag services. The README template-output wording was adjusted to refer to tag names instead of legacy service IDs.Impact
Consumers should use the modern
HtmlHeadTagManagerandHeadTagclasses. Legacy service IDs such ashuh.head.tag.*,TagManager, and classes underHeimrichHannot\HeadBundle\Tagare removed.Validation
php -lon all PHP files undersrc,config, andcontaogit diff --checkcomposer validatecould not be run locally because the checkout'scomposercommand is a DDEV wrapper and this directory has no.ddev/config.yaml.