Remove unused dependencies#520
Merged
Egyras merged 5 commits intoheishamon:masterfrom Sep 9, 2024
mi-hol:removeUnusedDependencies
Merged
Remove unused dependencies#520Egyras merged 5 commits intoheishamon:masterfrom mi-hol:removeUnusedDependencies
Egyras merged 5 commits intoheishamon:masterfrom
mi-hol:removeUnusedDependencies
Conversation
Contributor
Author
|
@IgorYbema looking at .github/workflows/main.yml Therefore the open question is: |
Member
|
No and I don't know how that got into the repo |
Contributor
No platformIO is not used. #376 is all it's history. |
Contributor
Author
|
thanks for clarification, I've amended PR accordingly |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With recent changes 2 dependencies became unused.
I went ahead and removed them but have no possibility to test the created bin yet!
Build action https://github.com/mi-hol/HeishaMon/actions/runs/10759232099 is successful