Skip to content

Remove unused dependencies#520

Merged
Egyras merged 5 commits intoheishamon:masterfrom
mi-hol:removeUnusedDependencies
Sep 9, 2024
Merged

Remove unused dependencies#520
Egyras merged 5 commits intoheishamon:masterfrom
mi-hol:removeUnusedDependencies

Conversation

@mi-hol
Copy link
Contributor

@mi-hol mi-hol commented Sep 8, 2024

With recent changes 2 dependencies became unused.
I went ahead and removed them but have no possibility to test the created bin yet!
Build action https://github.com/mi-hol/HeishaMon/actions/runs/10759232099 is successful

@mi-hol
Copy link
Contributor Author

mi-hol commented Sep 8, 2024

@IgorYbema looking at .github/workflows/main.yml
the command line is now:
run: arduino-cli lib install ringbuffer pubsubclient arduinojson dallastemperature onewire "Adafruit NeoPixel"

Therefore the open question is:
Is platformio.ini actually used?

@IgorYbema
Copy link
Member

No and I don't know how that got into the repo

@geduxas
Copy link
Contributor

geduxas commented Sep 8, 2024

@IgorYbema looking at .github/workflows/main.yml the command line is now: run: arduino-cli lib install ringbuffer pubsubclient arduinojson dallastemperature onewire "Adafruit NeoPixel"

Therefore the open question is: Is platformio.ini actually used?

No platformIO is not used. #376 is all it's history.

@mi-hol
Copy link
Contributor Author

mi-hol commented Sep 8, 2024

thanks for clarification, I've amended PR accordingly

@Egyras Egyras merged commit 99749aa into heishamon:master Sep 9, 2024
@mi-hol mi-hol deleted the removeUnusedDependencies branch September 11, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants