fix: handle wildcard and boolean values in CORS origin configuration#90
Merged
heitorrsdev merged 2 commits intomainfrom Apr 20, 2026
Merged
fix: handle wildcard and boolean values in CORS origin configuration#90heitorrsdev merged 2 commits intomainfrom
heitorrsdev merged 2 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes the CORS configuration logic to correctly handle the
ALLOWED_ORIGINSenvironment variable when set to "true" or "*", while maintaining support for comma-separated lists.What was done
parseAllowedOriginshelper insrc/app.config.ts.trueifALLOWED_ORIGINSis"true"or"*".falseifALLOWED_ORIGINSis undefined.test/cors.e2e.spec.tswith comprehensive scenarios covering all these cases.Why
The previous implementation incorrectly parsed
"true"as["true"], which caused CORS to reject requests and return HTTP 400 in deployment environments (like Render) that use this convention for public access. The new approach correctly maps these strings to the booleantrueexpected by NestJS's CORS middleware.