Merged
Conversation
giogix2
reviewed
May 6, 2025
| # inference settings | ||
| batch_size: 8 # Number of samples to process in each batch | ||
| emb_mode: "cell" # "gene" or "cell" | ||
| emb_mode: "gene" # "gene" or "cell" |
Contributor
There was a problem hiding this comment.
Should we leave "cell" as default? This is what's used in other models such as GeneFormer by default as well.
Contributor
Author
There was a problem hiding this comment.
Yes, good catch!
Just had it like that for testing
bputzeys
requested changes
May 6, 2025
Collaborator
bputzeys
left a comment
There was a problem hiding this comment.
make the device a Literal no?
bputzeys
approved these changes
May 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.