Merged
Conversation
Contributor
|
do we need the various loss functions, dataset classes if finetuning not supported? also no .ipynb? |
bputzeys
requested changes
Nov 24, 2025
raschedh
reviewed
Dec 2, 2025
raschedh
reviewed
Dec 2, 2025
Contributor
|
retry tests when cuda is available - tests pass locally |
Contributor
|
Ignore the entirety of the llm_foundry folder. It added about 4k lines. But we have no new dependencies now. |
Collaborator
|
If you want, you can exclude llm foundry and the other package files from our test coverage: https://github.com/helicalAI/helical/blob/release/.github/workflows/main.yml#L32 |
bputzeys
reviewed
Dec 4, 2025
bputzeys
reviewed
Dec 4, 2025
maxiallard
commented
Dec 8, 2025
bputzeys
approved these changes
Dec 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces support and documentation for the Tahoe-X1 model in the codebase, along with improvements to installation instructions and new tests for Tahoe-related components. The changes are grouped into documentation enhancements, workflow improvements, and new test coverage for Tahoe functionality.
IMPORTANT: Some Package Versions have been updated!
Documentation and Model Support:
Workflow and Dependency Management:
.github/workflows/main.ymlby switching topython -m pipcommands and adding comments for alternative installation scenarios, as well as using--no-cache-dirformamba-ssminstallation to ensure clean environments. [1] [2]Testing and Validation for Tahoe-X1:
TahoeConfigclass to validate default and custom configuration parameters, immutability, and HuggingFace repo ID settings.Tahoe-X1 Model Integration:
helical/models/tahoedirectory, includingTahoe,TahoeConfig, and thetahoe_x1submodule, allowing users to run Tahoe-X1 models natively in Helical. The integration is self-contained and follows Helical's API patterns. [1] [2]README.mdfor the Tahoe-X1 integration, detailing usage, features, attention implementations, dependencies, and model details.examples/run_models/configs/tahoe_config.yaml) and a runnable example script (examples/run_models/run_tahoe.py) demonstrating how to use the Tahoe model and extract embeddings and attention weights. [1] [2]Documentation and Installation Updates:
README.mdto include instructions for installing Helical with GPU and Flash Attention support, and added sections for installing Tahoe-X1 and other supported models. Also added references to Tahoe-X1 in the list of supported models and licenses. [1] [2] [3] [4] [5]Licensing and Attribution:
helical/models/tahoe/LICENSEand clarified copyright and adaptation details in the Tahoe-X1 README. [1] [2]