Skip to content

Conversation

@michaeldjeffrey
Copy link
Contributor

sqlx found it's way into the main compilation path of file-store, even though it was marked as optional.

This PR follows the pattern in helium-crypto-rs is hiding all sqlx related impls behind #[cfg(feature = 'sqlx-postgres')].

The sqlx-postgres feature is default enabled for file-store.
To test this, making a sample rust project with a file-store dependency will show that sqlx is not included unless it's asked for.

[dependencies]
file-store = { path = "../oracles/file_store", default-features = false }
> sqlx-test git:(master) ✗ cargo tree -i sqlx                 
error: package ID specification `sqlx` did not match any packages

`multisig` is unused in the project.
`sqlx-postgres` is not used in file-store.
Other workspaces depend on it as necessary.
@michaeldjeffrey michaeldjeffrey merged commit 5365699 into main Jun 9, 2025
27 checks passed
@michaeldjeffrey michaeldjeffrey deleted the mj/unsqlx-ize-file-store branch June 9, 2025 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants