Have location tracking in mobile-config track #1010
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kurotych
commented
Jun 24, 2025
|
|
||
| if self.asserted_location != radio.location { | ||
| self.asserted_location = radio.location; | ||
| self.asserted_location_changed_at = Some(radio.refreshed_at); |
Member
Author
There was a problem hiding this comment.
WDYT @bbalser Should we update last_changed_at here?
self.last_changed_at = radio.refreshed_at;
Contributor
There was a problem hiding this comment.
It makes sense to me since we're changing something about the radio. Unless last_changed_at is used for something other than change tracking.
Member
Author
There was a problem hiding this comment.
Yeah, but on the other hand, we're tracking location and the time it changed separately, so that's why I'm not sure what the best option is here.
michaeldjeffrey
approved these changes
Jun 26, 2025
bbalser
approved these changes
Jul 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous (duplicate) PR: #907
Add migration to back fill data.
usage
./target/debug/mobile-config -c mobile-config.toml migrate-mobile-tracker file.csv