Backfill use BatchedWriter#1187
Merged
Merged
Conversation
michaeldjeffrey
force-pushed
the
mj/backfill-use-batched-write
branch
from
896bccb to
710feff
Compare
michaeldjeffrey
force-pushed
the
mj/backfill-use-batched-write
branch
from
710feff to
029cfe9
Compare
bbalser
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Writing a single snapshot per backfilled file causes things to slow down quite dramatically.
Using the batched writer, we can queue writes, then flush them similar to file-store. With the same guarantees that we won't miss files if things fail because they're being persisted to disk.
This keeps backfill quite speedy, with intermittent pauses for flushing to iceberg.