Use batch_info v2 in mobile_config_cli #971
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kurotych
changed the title
mobile_config_cli/src/client.rs
Outdated
| Ok(()) => Some(res), | ||
| Err(_) => None, | ||
| Err(e) => { | ||
| eprintln!("Response verification failed. {e}"); |
Contributor
There was a problem hiding this comment.
Suggested change
| eprintln!("Response verification failed. {e}"); | |
| tracing::error!(?err, "Response verification failed"); |
Contributor
There was a problem hiding this comment.
do these tracing logs get output to the terminal stdout normally when operating the commands since this is in the context of an actual CLI (not just a clap construct for launching a server process) @michaeldjeffrey ? This seems like the one place where println! and eprintln! would be appropriate
jeffgrunewald
approved these changes
Mar 21, 2025
Contributor
jeffgrunewald
left a comment
jeffgrunewald
left a comment
There was a problem hiding this comment.
Looks good to me, assuming the custom tracing and tracing crate operations will output to a cli terminal as we would expect since we're in a foreground process operating directly with the application
bbalser
approved these changes
Apr 1, 2025
macpie
pushed a commit
that referenced
this pull request
Apr 14, 2025
* Print error if verification failed * Use v2 requests * Use tracing::error to print error message * Add DeploymentInfo
macpie
pushed a commit
that referenced
this pull request
Apr 14, 2025
* Print error if verification failed * Use v2 requests * Use tracing::error to print error message * Add DeploymentInfo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.