Update mobile-verifier to process new subscriber mapping activity reports #981
Conversation
| shutdown: triggered::Listener, | ||
| ) -> futures::future::LocalBoxFuture<'static, anyhow::Result<()>> { | ||
| Box::pin(self.run(shutdown)) | ||
| // let handle = tokio::spawn(async move { self.run(shutdown).await }); |
There was a problem hiding this comment.
@michaeldjeffrey I am hoping to actually spawn this, but when i do I get a weird lifetime issue that I haven't figured out yet, maybe you got some ideas?
There was a problem hiding this comment.
Addressed the lifetime issues here c68a9fb, not sure if it is the best way, but it seems to work
| AV: AuthorizationVerifier + Clone, | ||
| EV: EntityVerifier + Clone + Send + Sync + 'static, | ||
| AV: AuthorizationVerifier, | ||
| EV: EntityVerifier + Send + Sync + 'static, |
There was a problem hiding this comment.
Do we want to move Send + Sync + 'static to the definition of EntityVerifier as it will be required anywhere we use it?
There was a problem hiding this comment.
probably more concise: EntityVerifier: Send + Sync + 'static { trait functions }
There was a problem hiding this comment.
also looks like we're already doing this in the trait definition about the AuthorizationVerifier
Cargo.toml
Outdated
| [patch.'https://github.com/helium/proto'] | ||
| helium-proto = { git = "https://www.github.com/helium/proto.git", branch = "jg/disco-shares-v2" } |
There was a problem hiding this comment.
Might be nice to leave this as a comment when we move back to main branch. It probably won't be the last time we need to override a proto branch of a dep.
| #[async_trait] | ||
| pub trait AuthorizationVerifier: Send + Sync + 'static { | ||
| type Error; | ||
| type Error: std::error::Error + Send + Sync + 'static; |
There was a problem hiding this comment.
Since these are always ClientError can we remove the associated type?
| AV: AuthorizationVerifier + Clone, | ||
| EV: EntityVerifier + Clone + Send + Sync + 'static, | ||
| AV: AuthorizationVerifier, | ||
| EV: EntityVerifier + Send + Sync + 'static, |
There was a problem hiding this comment.
also looks like we're already doing this in the trait definition about the AuthorizationVerifier
…orts (#981) * Add receiving subscriber mapper activity requests to mobile ingestor * update mobile verifier to process subscriber mapper activity messages * update rewarder to use new subscriber mapping activity * making saving actvity idempotent and fix tests * remove unused subscriber_location and subscriber_verified mapping from mobile verifier * remove unused tests * Change to spawn tokio task and fix lifetime issues * remove commented out code * refactoring of subscriber mapping activity processing * move send/sync to trait definition * remove associated type for AuthorizationVerifier and EntityVerifier * update proto dep back to master * update beacon
…orts (#981) * Add receiving subscriber mapper activity requests to mobile ingestor * update mobile verifier to process subscriber mapper activity messages * update rewarder to use new subscriber mapping activity * making saving actvity idempotent and fix tests * remove unused subscriber_location and subscriber_verified mapping from mobile verifier * remove unused tests * Change to spawn tokio task and fix lifetime issues * remove commented out code * refactoring of subscriber mapping activity processing * move send/sync to trait definition * remove associated type for AuthorizationVerifier and EntityVerifier * update proto dep back to master * update beacon
No description provided.