stop outputing radio rewards v1 protos during mobile rewarding #996
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR removes the usage of RadioReward v1 protos during mobile rewarding, shifting the implementation to use only RadioRewardV2.
- Removed iteration and handling of mobile_reward_share_v1 in the reward loop.
- Updated the mobile reward share generation in reward_shares.rs to only return RadioRewardV2.
- Adjusted tests and CLI reward extraction to accommodate the new structure.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| mobile_verifier/src/rewarder.rs | Removed handling and writing of RadioReward v1, now only writing v2. |
| mobile_verifier/src/reward_shares.rs | Updated the coverage_point_to_mobile_reward_share function and related iterators to return only RadioRewardV2. |
| mobile_verifier/src/cli/reward_from_db.rs | Modified reward extraction logic to utilize only RadioRewardV2. |
kurotych
changed the title
bbalser
approved these changes
Apr 28, 2025
Contributor
|
|
michaeldjeffrey
approved these changes
Apr 28, 2025
jeffgrunewald
approved these changes
Apr 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.