Conversation
src/service/poc_mobile.proto
Outdated
| // The firmware version running on the hotspot. | ||
| string firmware_version = 3; | ||
| // Signer of the message | ||
| bytes signer_pubkey = 4; |
There was a problem hiding this comment.
@bbalser we should have a timestamp of when this message was generated, no?
That way someone can't grab an old written message and send it back in.
There was a problem hiding this comment.
I'm following the code style and added received_timestamp_ms field to enabled_carriers_info_report_v1. This field reflects time when the enabled_carriers_info_req_v1 was delivered to the ingest service.
There was a problem hiding this comment.
Yes, I'm talking about the case where some resends a signed message to the ingest service.
The received_timestamp_ms would reflect the timestamp of when it was received, but the message was generated who knows how long ago and may not be valid any longer.
There was a problem hiding this comment.
Good catch!
Added timestamp_ms = 4 to the message
kurotych
force-pushed
the
kurotych/carrier-enablement
branch
from
8012702 to
f4942fe
Compare
|
@kurotych anything holding this up? |
4 participants
No description provided.