Added kitty multicursor support#14
Conversation
the-mikedavis
left a comment
the-mikedavis
left a comment
There was a problem hiding this comment.
Querying for support should also be covered with a type in these changes. Helix should never write any explicit OSC or CSI commands
The err types match here so we can use the Result<T> type as-is.
the-mikedavis
left a comment
the-mikedavis
left a comment
There was a problem hiding this comment.
This is looking good, thanks!
I pushed some edits to align with the existing code a bit more. I'm very opinionated on how termina should expose protocols to consuming applications: we should try to hide protocol specifics like the values for each escape sequence within the impl Display as much as possible. To that end I removed a few sections here of TryFrom unless it was used by the parsing module, and the functions that exposed the protocol values as u8s.
I'll cut a new release with this now and take another look at the branch in Helix 👍
2 participants
Added CSI > parameter prefix parsing to support kitty multi-cursor protocol query responses.
Needed for helix-editor/helix#14757