Add escape sequences for setting/clearing foreground & background colors#17
Closed
fryeb wants to merge 2 commits intohelix-editor:masterfrom
Closed
Add escape sequences for setting/clearing foreground & background colors#17fryeb wants to merge 2 commits intohelix-editor:masterfrom
fryeb wants to merge 2 commits intohelix-editor:masterfrom
Conversation
I've used https://ghostty.org/docs/vt/concepts/colors#color-specifications as a reference. Thus far I've only added support for hexadecimal RGB with 8 bit color chanels. But this could be extended to support the other formats if desired.
78eeb50 to
3161d0e
Compare
Member
|
I like what WezTerm's OSC module does for this set of sequences, I think it fits the spec a bit more flexibly. I will partially merge this to steal your nice Cargo example 🙂 And I will look at updating & merging in your branch. I have my terminal configured with (probably too much) padding around the outside so adding support for this OSC is very visible to me! |
Member
|
Manually merged in b928da1. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisite for helix-editor/helix#15170
I've used https://ghostty.org/docs/vt/concepts/colors#color-specifications as a reference.
Thus far I've only added support for hexadecimal RGB with 8 bit color chanels. But this could be extended to support the other formats if desired.
See below screen recording (Ghostty v1.2.3 on MacOS Tahoe)
Screen.Recording.2026-01-29.at.12.52.16.pm.mov