Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new jupyter notebook tutorial for PIMU in stretch base #95

Merged
merged 6 commits into from
Sep 20, 2021

Conversation

hello-ag
Copy link
Contributor

No description provided.

Copy link
Contributor

@hello-binit hello-binit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hello-ag Thanks for opening this PR! Here are answers to the questions you've left within the notebook:

  • Question - any suggestions for checking PIMU?
    I'm not sure what this question is asking.

  • Question: Maybe I could write about the function of the fan.
    This would be a good idea. You can include information about the on-board NUC and how temperature affects performance.

  • Question: maybe we can find a better way to determine yrange here?
    I believe yrange is determined from calibration of the cliff sensors. You can investigate this.

  • Question: Maybe more description of the various IMU sensor readings could be added.
    Agreed, this would be helpful. Some people may not know what roll/pitch/yaw refers to.

  • Question: Any example of trigger_motor_sync I can use here?
    I recommend issuing motor commands to two steppers, and using push_command from the stepper class. Since trigger_motor_sync isn't automatically called, you'll find the motors won't move, and that the status reports that the motors are waiting for the motor sync to trigger. Then you can issue a trigger_motor_sync to see motion. Finally, you can explain how Robot.push_command handles all of this.


I recommend you clean up some of the empty cells and check for grammar/spelling. Finally, I'd add a README to the doc/ folder which explains how to use the jupyter command to visualize a .ipynb notebook file.

@hello-binit hello-binit merged commit d530385 into hello-robot:develop Sep 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants