Fields for gas sensor fw update #145
Conversation
|
For the sensor firmware update, the only version we need to compare is the |
periodic.proto
Outdated
| } | ||
|
|
||
| message tvoc_version { | ||
| optional uint32 tvoc_app_fw_version = 1; |
There was a problem hiding this comment.
Can you explain what these two fields represent? app_fw_version & boot_fw_version
There was a problem hiding this comment.
app_fw_version - sensor application firmware version
boot_fw_version - sensor boot firmware version.
Only the application firmware version needs to be compared in order to issue an update. Will add this in comments as well
|
Expected values for boot_fw_version and hw_fw_version can be ignored |
|
@divkam can you elaborate on how this is intended to be used? |
|
The motivation behind this change is to update the gas sensor application firmware to the latest version (as provided by the manufacturer). The application firmware is a *.bin file that is about 5kB in size. This file needs to be downloaded on to the device SD card. Once it is downloaded on the device SD card, device firmware will check the The firmware version will be part of the periodic upload, which the server can use to issue a sensor firmware update |
|
@divkam thanks. How do we intend to get it on the SD? Is it possible to use the presence of this file in the |
|
Download to SD card is using the existing FileDownload mechanism in the sync response. |
|
Ok, so why the extra Boolean? Can we infer that we should update by the presence of the file? |
|
The same download mechanism is used for sleep sound downloads. So, the file could be a tone instead of a firmware binary. |
|
As discussed with @pims, merging only the periodic upload of gas sensor firmware version for now. Will add additional fields (if needed) later for the sensor firmware update. |
periodic.proto
Outdated
| optional int32 uv_count = 7; | ||
| } | ||
|
|
||
| message tvoc_version { |
There was a problem hiding this comment.
the protobuf convention is to have message names be UpperCamelCase like KeywordStats for instance.
There was a problem hiding this comment.
it's not like we've been consistent, but it's good practice 😄
No description provided.