feat: [DEVOPS-2394] awss3exporter + CX endpoint unify + cx-js drop#1
Merged
jmsundar merged 1 commit intofeat/DEVOPS-2394-extend-otel-lambdafrom Apr 17, 2026
Conversation
…fork - Add awss3exporter dep to collector/lambdacomponents/go.mod (direct dep required since default.go imports it; was only indirect in collector/go.mod) - Fix pre-existing build break in origin/main: reconcile lambdacomponents + sub-module deps to v0.150.0, remove deprecated loggingexporter (replaced by debugexporter), update processorhelper API (NewTracesProcessor → NewTraces, etc.), switch MakeFactoryMap calls to otelcol.MakeFactoryMap with explicit type params (API moved to otelcol package in v0.150.0) - Unify 3 CX exporters to single ingress.us2.coralogix.com:443 in all 3 extend configs (cx-only, cx-arize, cx-arize-s3); all 3 pipelines (traces/metrics/logs) reference the single otlp/coralogix exporter - Update extend/README.md: new CX_ENDPOINT default, document cx-arize variant, add OPENTELEMETRY_COLLECTOR_CONFIG_URI config selection table, remove done TODO for awss3exporter go.mod, update build prereqs - Replace cx-js fork tgz ref with @opentelemetry/instrumentation@0.214.0 from npm in both layer/package.json and cx-wrapper/package.json - Simplify build_nodejs_layer.sh: drop OPENTELEMETRY_JS_PATH check + opentelemetry-js prepare/sdk-logs/instrumentation build blocks + tgz args from cx-wrapper and layer npm install (import-in-the-middle already from npm; only cx-js fork change was warn→debug log, no runtime impact) Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
jmsundar
changed the base branch from
main
to
feat/DEVOPS-2394-extend-otel-lambda
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part of DEVOPS-2394. See Plan A in the project plan for full context.
awss3exporteras a direct dep incollector/lambdacomponents/go.mod(it was only indirect incollector/go.mod;default.goalready imported it)origin/main: reconcileslambdacomponents+ sub-module deps to v0.150.0, removes deprecatedloggingexporter(replaced bydebugexporter), updatesprocessorhelperAPI (NewTracesProcessor->NewTracesetc.), switchesMakeFactoryMapcalls tootelcol.MakeFactoryMapwith explicit type params (API moved tootelcolpackage in v0.150.0)ingress.us2.coralogix.com:443endpoint across all 3 extend configs; all 3 pipelines (traces/metrics/logs) reference the singleotlp/coralogixexporterextend/README.md: newCX_ENDPOINTdefault, documentscx-arizevariant, addsOPENTELEMETRY_COLLECTOR_CONFIG_URIconfig-selection table, removes completed TODO.tgzref with@opentelemetry/instrumentation@0.214.0from npm inlayer/package.jsonandcx-wrapper/package.jsonbuild_nodejs_layer.sh: removesOPENTELEMETRY_JS_PATHcheck, opentelemetry-js build blocks, and stale tgz args from npm install callsTest plan
make -C collector build GOARCH=amd64andGOARCH=arm64both green (verified locally)build_nodejs_layer.shruns with onlyOPENTELEMETRY_JS_CONTRIB_PATHset (requires cx-contrib clone as sibling)🤖 Generated with Claude Code