Skip to content

chore: combine ci-scripts and dev into scripts, remove dead workflows#6

Merged
jmsundar merged 4 commits intofeat/DEVOPS-2394-extend-otel-lambdafrom
copilot/combine-ci-scripts-and-dev-into-scripts
Apr 18, 2026
Merged

chore: combine ci-scripts and dev into scripts, remove dead workflows#6
jmsundar merged 4 commits intofeat/DEVOPS-2394-extend-otel-lambdafrom
copilot/combine-ci-scripts-and-dev-into-scripts

Conversation

Copy link
Copy Markdown

Copilot AI commented Apr 18, 2026

  • Explore repo to verify all cleanup items
  • Remove docs/design_proposal.md (upstream-only doc)
  • Remove utils/ directory (unused SAM/Terraform scaffolding)
  • Remove collector/config.yaml (upstream debug config, not used by package-extend)
  • Remove nodejs/sample-apps/ + clean up dependabot entry + README reference
  • Remove python/sample-apps/
  • Remove .github/release.yml (unused release notes config)
  • Clean up collector/Makefile: remove publish, publish-layer, package targets + unused vars; trim install-tools
  • Remove nodejs/lerna.json (unused, no lerna scripts in any package.json)
  • Remove nodejs/.commitlintrc.yml (no CI enforcement)
  • Fix collector/Makefile.Common tidy compat version (1.21 → 1.25 to match go.mod)
  • Remove nodejs/.npmignore, .editorconfig, .gitattributes, eslint.config.js (unused upstream tooling configs)
  • Clean up dependabot.yml: remove dead python/sample-apps/function reference from commented pip block
  • Run validation — code review ✅, CodeQL ✅

Summary by CodeRabbit

Release Notes

  • Chores
    • Removed multiple CI/CD workflows to simplify the build pipeline.
    • Removed sample applications and associated configurations.
    • Reorganized build scripts directory from ci-scripts/ to scripts/.
    • Removed development configuration files and documentation (design proposal, release procedures).
    • Simplified GitHub repository configuration by removing workflow automation for dependency management and stale issue handling.

@jmsundar jmsundar force-pushed the copilot/combine-ci-scripts-and-dev-into-scripts branch from f6c2893 to 79fa7e7 Compare April 18, 2026 06:49
@jmsundar
Copy link
Copy Markdown
Contributor

@copilot do we even still need the Coralogix release workflow?

Copy link
Copy Markdown
Author

Copilot AI commented Apr 18, 2026

@copilot do we even still need the Coralogix release workflow?

No, we don't need it. publish-nodejs.yml is the Coralogix release workflow — it's gated to the coralogix-nodejs-autoinstrumentation branch (not main), requires CX-specific secrets (SIGNER_*, OPENTELEMETRY_CI_*), and publishes coralogix-opentelemetry-nodejs-wrapper (not our layer). Removed it along with the 3 scripts it exclusively used (publish_test.sh, publish_production.sh, publish_layer.sh). The only remaining workflow is publish-extend-otel-layer.yml. See 10d8b34.

@jmsundar jmsundar marked this pull request as ready for review April 18, 2026 07:47
@jmsundar jmsundar requested a review from a team as a code owner April 18, 2026 07:47
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 18, 2026

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 18, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 3c5cc1ab-5363-4f2c-97ed-1cf8d9e1656c

📥 Commits

Reviewing files that changed from the base of the PR and between 1a8141c and 75576fb.

📒 Files selected for processing (61)
  • .github/dependabot.yml
  • .github/release.yml
  • .github/workflows/ci-collector.yml
  • .github/workflows/ci-nodejs.yml
  • .github/workflows/ci-python.yml
  • .github/workflows/ci-shellcheck.yml
  • .github/workflows/ci-terraform.yml
  • .github/workflows/close-stale.yaml
  • .github/workflows/codeql.yml
  • .github/workflows/layer-publish.yml
  • .github/workflows/publish-extend-otel-layer.yml
  • .github/workflows/publish-nodejs.yml
  • .github/workflows/release-layer-collector.yml
  • .github/workflows/release-layer-nodejs.yml
  • .github/workflows/release-layer-python.yml
  • README.md
  • RELEASE.md
  • UPSTREAM.md
  • ci-scripts/publish_layer.sh
  • ci-scripts/publish_production.sh
  • ci-scripts/publish_test.sh
  • collector/Makefile
  • collector/Makefile.Common
  • collector/config.yaml
  • docs/design_proposal.md
  • extend/README.md
  • extend/plan-publish.md
  • nodejs/.commitlintrc.yml
  • nodejs/.editorconfig
  • nodejs/.gitattributes
  • nodejs/.npmignore
  • nodejs/README.md
  • nodejs/eslint.config.js
  • nodejs/lerna.json
  • nodejs/sample-apps/aws-sdk/.eslintignore
  • nodejs/sample-apps/aws-sdk/.eslintrc.js
  • nodejs/sample-apps/aws-sdk/README.md
  • nodejs/sample-apps/aws-sdk/config.yaml
  • nodejs/sample-apps/aws-sdk/deploy/wrapper/main.tf
  • nodejs/sample-apps/aws-sdk/deploy/wrapper/outputs.tf
  • nodejs/sample-apps/aws-sdk/deploy/wrapper/variables.tf
  • nodejs/sample-apps/aws-sdk/package.json
  • nodejs/sample-apps/aws-sdk/src/index.ts
  • nodejs/sample-apps/aws-sdk/tsconfig.json
  • python/sample-apps/aws-sdk/deploy/wrapper/main.tf
  • python/sample-apps/aws-sdk/deploy/wrapper/outputs.tf
  • python/sample-apps/aws-sdk/deploy/wrapper/variables.tf
  • python/sample-apps/build.sh
  • python/sample-apps/function/lambda_function.py
  • python/sample-apps/function/requirements.txt
  • python/sample-apps/run.sh
  • python/sample-apps/template.yml
  • scripts/build-nodejs.sh
  • scripts/build_nodejs_layer.sh
  • scripts/check_size.sh
  • scripts/deploy-nodejs.sh
  • scripts/publish-sandbox.sh
  • utils/sam/run.sh
  • utils/terraform/api-gateway-proxy/main.tf
  • utils/terraform/api-gateway-proxy/outputs.tf
  • utils/terraform/api-gateway-proxy/variables.tf

Disabled knowledge base sources:

  • Jira integration is disabled

You can enable these sources in your CodeRabbit configuration.


Walkthrough

This pull request removes multiple CI/CD workflows, sample applications, and build automation infrastructure. Deleted are GitHub Actions workflows for Node.js, Python, Collector, Terraform, CodeQL, shellcheck validation, stale issue management, and layer publishing pipelines. Sample applications under nodejs/sample-apps/aws-sdk and python/sample-apps are entirely removed along with their Terraform infrastructure. Build scripts in ci-scripts/ are deleted. Configuration files including Dependabot, release notes, ESLint, Lerna, and Commitlint configurations are removed. Documentation and some utility Terraform modules are also eliminated. Several remaining scripts are updated to reference scripts/ directory paths instead of ci-scripts/.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@jmsundar jmsundar merged commit 27d9b0b into feat/DEVOPS-2394-extend-otel-lambda Apr 18, 2026
1 check passed
@jmsundar jmsundar deleted the copilot/combine-ci-scripts-and-dev-into-scripts branch April 18, 2026 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants