Skip to content

upgrade bootstrap 5.3.0#301

Merged
greyli merged 1 commit intohelloflask:masterfrom
PanderMusubi:bootstrap53
Jul 23, 2023
Merged

upgrade bootstrap 5.3.0#301
greyli merged 1 commit intohelloflask:masterfrom
PanderMusubi:bootstrap53

Conversation

@PanderMusubi
Copy link
Copy Markdown
Collaborator

No description provided.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 30, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (ed59d2a) 100.00% compared to head (e47e691) 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #301   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines          136       136           
  Branches        16        16           
=========================================
  Hits           136       136           
Impacted Files Coverage Δ
flask_bootstrap/__init__.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Copy Markdown
Member

@greyli greyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default CDN version and integrity values should be updated as well. https://github.com/helloflask/bootstrap-flask/blob/master/flask_bootstrap/__init__.py#L262-L266

@PanderMusubi
Copy link
Copy Markdown
Collaborator Author

The default CDN version and integrity values should be updated as well. https://github.com/helloflask/bootstrap-flask/blob/master/flask_bootstrap/__init__.py#L262-L266

Thanks. Will do later today.

@PanderMusubi
Copy link
Copy Markdown
Collaborator Author

Done, also updated #300

@PanderMusubi
Copy link
Copy Markdown
Collaborator Author

@greyli I see there is also an upgrade of popper from 2.11.6 to 2.11.8. Add that also to this PR?

@PanderMusubi
Copy link
Copy Markdown
Collaborator Author

@greyli I also see Bootswatch is at 5.3.0 now. I will upgrade that and popper this week and hope we can release soon after that if is okay with you?

@PanderMusubi PanderMusubi self-assigned this Jun 14, 2023
@greyli
Copy link
Copy Markdown
Member

greyli commented Jun 18, 2023

I also see Bootswatch is at 5.3.0 now. I will upgrade that and popper this week and hope we can release soon after that if is okay with you?

LGTM.

@greyli
Copy link
Copy Markdown
Member

greyli commented Jul 23, 2023

Merged. I will upgrade Popper and then release 2.3.0.

@greyli greyli merged commit 13419d8 into helloflask:master Jul 23, 2023
@PanderMusubi PanderMusubi deleted the bootstrap53 branch August 22, 2023 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants