Skip to content
This repository was archived by the owner on Sep 6, 2025. It is now read-only.

Add timeout of 30 seconds to all requests#18

Merged
brunoliveira8 merged 2 commits intomasterfrom
hotfix/add-timeout-to-requests
Oct 26, 2018
Merged

Add timeout of 30 seconds to all requests#18
brunoliveira8 merged 2 commits intomasterfrom
hotfix/add-timeout-to-requests

Conversation

@brunoliveira8
Copy link
Copy Markdown
Contributor

Description

By default, the Requests library does not have a timeout that means the code may hang for minutes or more waiting for a server response.

References

http://docs.python-requests.org/en/master/user/advanced/#timeouts

@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 25, 2018

Codecov Report

Merging #18 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #18   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           2      2           
  Lines         132    132           
=====================================
  Hits          132    132
Impacted Files Coverage Δ
crossengage/client.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 218314c...ea17321. Read the comment docs.

@omarch7
Copy link
Copy Markdown
Contributor

omarch7 commented Oct 26, 2018

👍

Approved with PullApprove Approved with PullApprove

@fernando-fonseca
Copy link
Copy Markdown

fernando-fonseca commented Oct 26, 2018

+1

Approved with PullApprove Approved with PullApprove

@brunoliveira8 brunoliveira8 merged commit be741f2 into master Oct 26, 2018
@brunoliveira8 brunoliveira8 deleted the hotfix/add-timeout-to-requests branch October 26, 2018 09:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants