Skip to content

Update OpenTelemetry #268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lucasmdrs merged 4 commits into from
Aug 15, 2023
Merged

Update OpenTelemetry #268

lucasmdrs merged 4 commits into from
Aug 15, 2023

Conversation

@lucasmdrs
Copy link
Contributor

@lucasmdrs lucasmdrs commented Aug 3, 2023 •
edited
Loading

  • Update OpenTelemetry to latest version
  • Fix a few missed error wrapping returns
  • Remove a few labels from HTTP server metrics

Before version 1.6.0:

http_server_duration_bucket:
    http_flavor
    http_host
    http_method
    http_scheme
    http_server_name

Version 1.6.0:

http_server_duration_bucket
    http_flavor
    http_method
    http_scheme
    http_status_code
    http_user_agent
    net_host_name
    net_host_port
    net_sock_peer_addr
    net_sock_peer_port
    otel_scope_name
    otel_scope_version

This PR:

http_server_duration_bucket
    http_flavor
    http_method
    http_scheme
    http_status_code
    otel_scope_name
    otel_scope_version

@lucasmdrs lucasmdrs marked this pull request as ready for review August 15, 2023 09:21
s-radyuk
s-radyuk approved these changes Aug 15, 2023
View reviewed changes
Copy link
Contributor

@s-radyuk s-radyuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@lucasmdrs lucasmdrs merged commit d18cdd3 into master Aug 15, 2023
@lucasmdrs lucasmdrs deleted the patch/update-otel branch August 15, 2023 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@s-radyuk s-radyuk s-radyuk approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lucasmdrs @s-radyuk