Typo in docs for CPU limit #296
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucasmdrs
approved these changes
Nov 9, 2023
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## master #296 +/- ##
=======================================
Coverage 56.04% 56.04%
=======================================
Files 37 37
Lines 4116 4116
=======================================
Hits 2307 2307
Misses 1686 1686
Partials 123 123 |
Contributor
|
Thank you for the contribution @thiagoarrais 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just got bitten by this. Here is a PR for fixing a typo in the docs. The variable name in
pkg/backends/jmeter/config.gois namedJMETER_MASTER_CPU_LIMITS, notJMETER_MASTER_CPU_LIMIT.