Skip to content
This repository was archived by the owner on Oct 17, 2023. It is now read-only.

Refactor HTTP client and update automated tests.#34

Merged
cmpaul merged 17 commits intov3from
issue-13
Feb 2, 2017
Merged

Refactor HTTP client and update automated tests.#34
cmpaul merged 17 commits intov3from
issue-13

Conversation

@cmpaul
Copy link
Copy Markdown
Contributor

@cmpaul cmpaul commented Jan 20, 2017

This closes issue #13 .

Potentially breaking changes:

  • The following now return boolean instead of int:
    • HelloSignClient.cancelSignatureRequest()
    • HelloSignClient.destroyTeam()

Other, non-breaking changes:

  • Refactored HTTP client code to be testable.
  • Deprecating all HelloSignClient.getOauthData methods that do not send a state parameter.
  • Rebuilt JUnit tests to run off Mockito using pre-generated responses.
  • Added travis-ci config to run tests against all changes.
  • Reformatted entire code base.

@cmpaul cmpaul requested a review from jon-eckstein January 20, 2017 21:38
@cmpaul
Copy link
Copy Markdown
Contributor Author

cmpaul commented Jan 23, 2017

Notes from review:

  • Bump to 4.0.0 due to breaking changes listed.
  • Remove methods for getOauthData that don't include a state parameter
  • Update DEFAULT_OAUTH_TOKEN_URL to app.*
  • Make HttpClient injectable through the protected constructor, update tests
  • Remove HelloSignClient(String email, String password)
  • Remove HelloSignClient(Authentication auth)
  • Don't swallow exception in isAccountValid()
  • Remove createAccount(String email, String password)
  • Remove createAccount(String email, String password, String clientId, String clientSecret)

@cmpaul cmpaul merged commit 1be8e44 into v3 Feb 2, 2017
@cmpaul cmpaul deleted the issue-13 branch February 2, 2017 00:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants