Skip to content
This repository was archived by the owner on Oct 17, 2023. It is now read-only.

Add allow decline#64

Merged
michaelnlindsay merged 6 commits intohellosign:v3from
radhack:addAllowDecline
Mar 1, 2018
Merged

Add allow decline#64
michaelnlindsay merged 6 commits intohellosign:v3from
radhack:addAllowDecline

Conversation

@radhack
Copy link
Copy Markdown
Contributor

@radhack radhack commented Feb 22, 2018

No description provided.

Comment thread library/HelloSign/AbstractResource.php Outdated
/**
* @return SignatureRequest
* @ignore
* this is the default
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a protected member variable for this with default value of true

*/
return $this->request->toParams(array(
'except' => array('allow_decline')

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might consider keeping the except key and passing an empty array to that for future exceptions?

@michaelnlindsay michaelnlindsay merged commit 66b1950 into hellosign:v3 Mar 1, 2018
@radhack radhack mentioned this pull request Mar 1, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants