You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Oct 17, 2023. It is now read-only.
The get_signature_request_file method takes a filename, fetches the contents from the server and writes to this filename. This is a problem if the file is not stored locally (S3 in my case).
Potential solutions:
Make get_signature_request_file also accept a writable file-like object.
Make the filename parameter optional, and in it's absense return the contents as a string ?
I'd be happy to submit a PR if we can decide on a solution. I prefer the first one above, unless anyone else can propose a better solution.
The
get_signature_request_filemethod takes a filename, fetches the contents from the server and writes to this filename. This is a problem if the file is not stored locally (S3 in my case).Potential solutions:
get_signature_request_filealso accept a writable file-like object.filenameparameter optional, and in it's absense return the contents as a string ?I'd be happy to submit a PR if we can decide on a solution. I prefer the first one above, unless anyone else can propose a better solution.