Skip to content
This repository was archived by the owner on Oct 17, 2023. It is now read-only.
This repository was archived by the owner on Oct 17, 2023. It is now read-only.

Getting the contents of a signature request file #12

@arshsingh

Description

@arshsingh

The get_signature_request_file method takes a filename, fetches the contents from the server and writes to this filename. This is a problem if the file is not stored locally (S3 in my case).

Potential solutions:

  1. Make get_signature_request_file also accept a writable file-like object.
  2. Make the filename parameter optional, and in it's absense return the contents as a string ?

I'd be happy to submit a PR if we can decide on a solution. I prefer the first one above, unless anyone else can propose a better solution.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions