[codex] Add webchat teaser positioning behavior#44
Merged
rockwellll merged 10 commits intomainfrom Apr 28, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
usePopoverstrategy overrides, and emoji picker positioning.libanddistoutputs.Why
The teaser and emoji picker need their own positioning behavior so they do not inherit the main webchat strategy in cases where that would place the floating UI incorrectly. The teaser also should not reappear when there is no teaser body to show.
Validation
npm testNote
Medium Risk
Touches webchat popover positioning and open/close UI behavior, which could cause regressions in widget layout/visibility across configurations and devices.
Overview
Adds support for overriding
usePopover’s Floating UIstrategyper popover (falling back toConfiguration.webchat.strategywhen omitted).Updates
WebchatControllerto position the teaser independently from the main popover usingstrategy: 'absolute', hide the teaser when the chat opens, and only re-show it on close whenteaserValue.bodyis present; keepsEmojiPickerControllerexplicitly positioned withstrategy: 'absolute'. Includes new Jest coverage forusePopoverstrategy selection, teaser positioning/visibility, and emoji picker positioning, and updates generatedliboutputs accordingly.Reviewed by Cursor Bugbot for commit 7bb1c54. Bugbot is set up for automated code reviews on this repo. Configure here.