[codex] Handle webchat reconnect catch-up#50
Merged
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8cfd2cf0c3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Server dependency
Why
When a deploy replaces the Docker image, the WebSocket can drop while the page is still open. The SDK now restores the subscription and asks the server for messages created after the last rendered persisted message, closing the small window where a message could otherwise be missed.
Validation
Note
Medium Risk
Changes live messaging, reconnect, and message ordering; behavior depends on the new backend catch-up API and must stay aligned with realtime delivery.
Overview
Adds webchat reconnect recovery so an open widget can survive ActionCable drops (for example during deploys) without missing messages.
The shared
ApplicationChannelnow replaces dead sockets, debounces reconnects, replays message handlers, and resubscribes active channels afteropen. It also exposesonDisconnectandonSubscriptionConfirmedhooks for control frames.WebchatChanneltracks subscription intent,resubscribeonly when still subscribed, and runsonReconnectcallbacks only after a matchingconfirm_subscriptionfor this webchat/session/conversation.WebchatMessagesAPI.catchUpfetches messages withafter_idand session.WebchatControllersnapshots the last rendered message id on disconnect, calls catch-up after reconnect confirmation, and inserts recovered messages bycreated_atso backfill sits before newer realtime bubbles.lib/distoutputs are rebuilt.Depends on the server catch-up endpoint in hellotext PR 4757.
Reviewed by Cursor Bugbot for commit 8cfd2cf. Bugbot is set up for automated code reviews on this repo. Configure here.