Reset cfg test by hellt · Pull Request #3 · hellt/kne

hellt · 2022-08-04T14:50:55Z

Hey @carlmontanari
I know you sup busy, so whenver you're there I'd appreaciate your expert opinion on a strange thing I see in scrapligo (v1.2.2) test.

Namely in this PR you see a newly added test function added called TestResetCfg which acts on an file input with send/recv chars.
The issue I am seeing is that scrapligo doesn't emit an error when the written bytes don't match the received ones.

Here is a snippet from the test execution with verbose logging:
go test -timeout 30s -v -run ^TestResetCfg$ github.com/openconfig/kne/topo/node/srl

/root/openconfig/kne/topo/node/srl/logging.go:54:     INFO SendCommand requested, sending 'load factory auto-commit'
    /root/openconfig/kne/topo/node/srl/logging.go:54:    DEBUG channel SendInput requested, sending input 'load factory auto-commit'
    /root/openconfig/kne/topo/node/srl/logging.go:54:    DEBUG channel write "load factory auto-commit"
    /root/openconfig/kne/topo/node/srl/logging.go:54:    DEBUG channel read " enter candidate private\n--{ candidate private private-admin }--[  ]--\nA:pod1# load factory auto-commit"
    /root/openconfig/kne/topo/node/srl/logging.go:54:    DEBUG channel write "\n"
    /root/openconfig/kne/topo/node/srl/logging.go:54:    DEBUG channel read "  \n/system/configuration/checkpoint[id=__factory__]:\n    Reverting to factory configuration\n\n/:\n    Preamble must be present in configuration file\n\n/:\n    Successfully reverted configuration\n\n--{ + candidate private private-admin }--[  ]--\nA:pod1#"
time="2022-08-04T16:38:52+02:00" level=info msg="pod1 - finished resetting config"

The bad stuff happens on line 3, where we write load factory auto-commit, but we read back some other line and no error is sent back.

Full log below

Details

``` Running tool: /root/sdk/go1.18.4/bin/go test -timeout 30s -run ^TestResetCfg$ github.com/openconfig/kne/topo/node/srl

=== RUN TestResetCfg
=== RUN TestResetCfg/success
time="2022-08-04T16:38:52+02:00" level=info /root/openconfig/kne/topo/node/srl/logging.go:54: /root/openconfig/kne/topo/node/srl/logging.go:54: /root/openconfig/kne/topo/node/srl/logging.go:54: /root/openconfig/kne/topo/node/srl/logging.go:54: /root/openconfig/kne/topo/node/srl/logging.go:54: /root/openconfig/kne/topo/node/srl/logging.go:54: /root/openconfig/kne/topo/node/srl/logging.go:54: /root/openconfig/kne/topo/node/srl/logging.go:54: /root/openconfig/kne/topo/node/srl/logging.go:54: /root/openconfig/kne/topo/node/srl/logging.go:54: /root/openconfig/kne/topo/node/srl/logging.go:54: /root/openconfig/kne/topo/node/srl/logging.go:54: /root/openconfig/kne/topo/node/srl/logging.go:54: /root/openconfig/kne/topo/node/srl/logging.go:54: /root/openconfig/kne/topo/node/srl/logging.go:54: /root/openconfig/kne/topo/node/srl/logging.go:54: /root/openconfig/kne/topo/node/srl/logging.go:54: /root/openconfig/kne/topo/node/srl/logging.go:54: /root/openconfig/kne/topo/node/srl/logging.go:54: /root/openconfig/kne/topo/node/srl/logging.go:54: /root/openconfig/kne/topo/node/srl/logging.go:54: /root/openconfig/kne/topo/node/srl/logging.go:54: /root/openconfig/kne/topo/node/srl/logging.go:54: /root/openconfig/kne/topo/node/srl/logging.go:54: /root/openconfig/kne/topo/node/srl/logging.go:54: /root/openconfig/kne/topo/node/srl/logging.go:54: /root/openconfig/kne/topo/node/srl/logging.go:54: /root/openconfig/kne/topo/node/srl/logging.go:54: /root/openconfig/kne/topo/node/srl/logging.go:54: /root/openconfig/kne/topo/node/srl/logging.go:54: /root/openconfig/kne/topo/node/srl/logging.go:54: /root/openconfig/kne/topo/node/srl/logging.go:54: /root/openconfig/kne/topo/node/srl/logging.go:54: /root/openconfig/kne/topo/node/srl/logging.go:54: /root/openconfig/kne/topo/node/srl/logging.go:54: /root/openconfig/kne/topo/node/srl/logging.go:54: /root/openconfig/kne/topo/node/srl/logging.go:54: /root/openconfig/kne/topo/node/srl/logging.go:54: /root/openconfig/kne/topo/node/srl/logging.go:54: time="2022-08-04T16:38:52+02:00" level=info /root/openconfig/kne/topo/node/srl/logging.go:54: /root/openconfig/kne/topo/node/srl/logging.go:54: /root/openconfig/kne/topo/node/srl/logging.go:54: /root/openconfig/kne/topo/node/srl/logging.go:54: /root/openconfig/kne/topo/node/srl/logging.go:54: /root/openconfig/kne/topo/node/srl/logging.go:54: /root/openconfig/kne/topo/node/srl/logging.go:54: /root/openconfig/kne/topo/node/srl/logging.go:54: /root/openconfig/kne/topo/node/srl/logging.go:54: /root/openconfig/kne/topo/node/srl/logging.go:54: /root/openconfig/kne/topo/node/srl/logging.go:54: --- PASS: TestResetCfg (2.01s)
--- PASS: TestResetCfg/success (2.01s)
PASS
ok github.com/openconfig/kne/topo/node/srl msg="pod1 resetting config"
DEBUG opening connection to host 'pod1' on port '22'
DEBUG starting channel read loop
DEBUG auth bypass is enabled, skipping in channel auth check
INFO connection opened successfully
INFO AcquirePriv requested, target privilege level 'exec'
DEBUG channel GetPrompt requested
DEBUG channel write "\n"
DEBUG channel read "Using configuration file(s): []\nWelcome to the srlinux CLI.\nType 'help' (and press ) if you need any help using this.\nWarning: Running in basic cli engine, only limited set of features is enabled.\n--{ running }--[ ]--\nA:pod1#"
DEBUG AcquirePriv determined no privilege action necessary
INFO SendCommand requested, sending 'environment cli-engine type basic'
DEBUG channel SendInput requested, sending input 'environment cli-engine type basic'
DEBUG channel write "environment cli-engine type basic"
DEBUG channel read " environment cli-engine type basic"
DEBUG channel write "\n"
DEBUG channel read "\n--{ running }--[ ]--\nA:pod1#"
INFO SendCommand requested, sending 'environment complete-on-space false'
DEBUG channel SendInput requested, sending input 'environment complete-on-space false'
DEBUG channel write "environment complete-on-space false"
DEBUG channel read " environment complete-on-space false"
DEBUG channel write "\n"
DEBUG channel read "\n--{ + running }--[ ]--\nA:pod1#"
INFO SendCommand requested, sending 'info from state system app-management application mgmt_server state | grep running'
DEBUG channel SendInput requested, sending input 'info from state system app-management application mgmt_server state | grep running'
DEBUG channel write "info from state system app-management application mgmt_server state | grep running"
DEBUG channel read " info from state system app-management application mgmt_server state | grep running"
DEBUG channel write "\n"
DEBUG channel read "\n state running\n--{ running }--[ ]--\nA:pod1#"
INFO SendCommand requested, sending 'info from state system configuration commit 1 status | grep complete'
DEBUG channel SendInput requested, sending input 'info from state system configuration commit 1 status | grep complete'
DEBUG channel write "info from state system configuration commit 1 status | grep complete"
DEBUG channel read " info from state system configuration commit 1 status | grep complete"
DEBUG channel write "\n"
DEBUG channel read "\n status complete\n--{ running }--[ ]--\nA:pod1#"
INFO SendCommand requested, sending 'load factory auto-commit'
DEBUG channel SendInput requested, sending input 'load factory auto-commit'
DEBUG channel write "load factory auto-commit"
DEBUG channel read " enter candidate private\n--{ candidate private private-admin }--[ ]--\nA:pod1# load factory auto-commit"
DEBUG channel write "\n"
DEBUG channel read " \n/system/configuration/checkpoint[id=factory]:\n Reverting to factory configuration\n\n/:\n Preamble must be present in configuration file\n\n/:\n Successfully reverted configuration\n\n--{ + candidate private private-admin }--[ ]--\nA:pod1#"
msg="pod1 - finished resetting config"
INFO AcquirePriv requested, target privilege level 'exec'
DEBUG channel GetPrompt requested
DEBUG channel write "\n"
DEBUG channel read "\n--{ + candidate private private-admin }--[ ]--\nA:pod1#"
DEBUG AcquirePriv determined privilege de-escalation necessary
DEBUG channel SendInput requested, sending input 'discard now'
DEBUG channel write "discard now"
CRITICAL channel timeout sending input to device
CRITICAL error running network on close, error: errTimeoutError: channel timeout sending input to device
DEBUG closing connection to host 'pod1' on port '22'
INFO connection closed successfully
2.029s

</details>

coveralls · 2022-08-04T14:53:12Z

Pull Request Test Coverage Report for Build 2798317358

14 of 20 (70.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.05%) to 53.883%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
topo/node/srl/srl.go	14	20	70.0%

Totals
Change from base Build 2797510355:	0.05%
Covered Lines:	1908
Relevant Lines:	3541

💛 - Coveralls

Hobbydos and others added 3 commits July 30, 2022 12:13

implementing resetter for srlinux

a19c0b9

Merge branch 'main' into Hobbydos/main

3336fd4

init resetcfg test boilerplate

58da866

hellt and others added 3 commits August 4, 2022 17:47

added closing sequence

de15d69

added sucess and failure cases

abfaa5a

Update srl_test.go

6f931a0

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Reset cfg test#3

Reset cfg test#3
hellt wants to merge 6 commits intomainfrom
reset-cfg-test

hellt commented Aug 4, 2022 •

edited

Loading

Uh oh!

coveralls commented Aug 4, 2022 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

hellt commented Aug 4, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coveralls commented Aug 4, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Test Coverage Report for Build 2798317358

💛 - Coveralls

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

hellt commented Aug 4, 2022 •

edited

Loading

coveralls commented Aug 4, 2022 •

edited

Loading