Add option to exclude deprecated charts#280
Merged
unguiculus merged 2 commits intohelm:masterfrom Oct 27, 2020
Merged
Conversation
Adds a new configuration option that allows a user to exclude deprecated charts from testing. Signed-off-by: Eric Lemieux <eric@lemieuxdev.com>
EricLemieux
force-pushed
the
feat-exclude-deprecated
branch
from
46df4fb to
572a924
Compare
unguiculus
approved these changes
Oct 27, 2020
Signed-off-by: Reinhard Nägele <unguiculus@gmail.com>
unguiculus
force-pushed
the
feat-exclude-deprecated
branch
from
1679edc to
0077e9f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds a new configuration option that allows a user to exclude deprecated charts from testing.
Which issue this PR fixes
fixes #261
Special notes for your reviewer:
I was able to validate some of the behavior manually by linting a deprecated chart, unsure about the best approach to automate that testing, perhaps in the integration_test.go tests.
Decided to hold off on implementing for now, as I realize this flag might need to be discussed.