Skip to content

Remove redundant "default" descriptions from help output#287

Merged
unguiculus merged 3 commits intohelm:masterfrom
flimzy:defaults
Oct 28, 2020
Merged

Remove redundant "default" descriptions from help output#287
unguiculus merged 3 commits intohelm:masterfrom
flimzy:defaults

Conversation

@flimzy
Copy link
Contributor

@flimzy flimzy commented Oct 15, 2020

Diff of before/after output:

--- before      2020-10-15 08:28:33.285100444 +0200
+++ after       2020-10-15 08:30:53.983319078 +0200
@@ -30,7 +30,7 @@
       --charts strings                 Specific charts to test. Disables changed charts detection and
                                        version increment checking. May be specified multiple times
                                        or separate values with commas
-      --check-version-increment        Activates a check for chart version increments (default: true) (default true)
+      --check-version-increment        Activates a check for chart version increments (default true)
       --config string                  Config file
       --debug                          Print CLI calls of external tools to stdout (caution: setting this may
                                        expose sensitive data when helm-repo-extra-args contains passwords)
@@ -49,7 +49,7 @@
       --remote string                  The name of the Git remote used to identify changed charts (default "origin")
       --since string                   The Git reference used to identify changed charts (default "HEAD")
       --target-branch string           The name of the target branch used to identify changed charts (default "master")
-      --validate-chart-schema          Enable schema validation of 'Chart.yaml' using Yamale (default: true) (default true)
-      --validate-maintainers           Enable validation of maintainer account names in chart.yml (default: true).
+      --validate-chart-schema          Enable schema validation of 'Chart.yaml' using Yamale (default true)
+      --validate-maintainers           Enable validation of maintainer account names in chart.yml.
                                        Works for GitHub, GitLab, and Bitbucket (default true)
-      --validate-yaml                  Enable linting of 'Chart.yaml' and values files (default: true) (default true)
+      --validate-yaml                  Enable linting of 'Chart.yaml' and values files (default true)

What this PR does / why we need it:

The help output (and .md docs created from it) contains redudant text.

flimzy and others added 3 commits October 15, 2020 08:44
Diff of before/after output:

--- before      2020-10-15 08:28:33.285100444 +0200
+++ after       2020-10-15 08:30:53.983319078 +0200
@@ -30,7 +30,7 @@
       --charts strings                 Specific charts to test. Disables changed charts detection and
                                        version increment checking. May be specified multiple times
                                        or separate values with commas
-      --check-version-increment        Activates a check for chart version increments (default: true) (default true)
+      --check-version-increment        Activates a check for chart version increments (default true)
       --config string                  Config file
       --debug                          Print CLI calls of external tools to stdout (caution: setting this may
                                        expose sensitive data when helm-repo-extra-args contains passwords)
@@ -49,7 +49,7 @@
       --remote string                  The name of the Git remote used to identify changed charts (default "origin")
       --since string                   The Git reference used to identify changed charts (default "HEAD")
       --target-branch string           The name of the target branch used to identify changed charts (default "master")
-      --validate-chart-schema          Enable schema validation of 'Chart.yaml' using Yamale (default: true) (default true)
-      --validate-maintainers           Enable validation of maintainer account names in chart.yml (default: true).
+      --validate-chart-schema          Enable schema validation of 'Chart.yaml' using Yamale (default true)
+      --validate-maintainers           Enable validation of maintainer account names in chart.yml.
                                        Works for GitHub, GitLab, and Bitbucket (default true)
-      --validate-yaml                  Enable linting of 'Chart.yaml' and values files (default: true) (default true)
+      --validate-yaml                  Enable linting of 'Chart.yaml' and values files (default true)

Signed-off-by: Jonathan Hall <flimzy@flimzy.com>
Signed-off-by: Reinhard Nägele <unguiculus@gmail.com>
Signed-off-by: Reinhard Nägele <unguiculus@gmail.com>
Copy link
Member

@unguiculus unguiculus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@unguiculus unguiculus merged commit e287de0 into helm:master Oct 28, 2020
@flimzy flimzy deleted the defaults branch October 28, 2020 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants