Skip to content

Added --history-limit option.#135

Closed
aleerizw-zz wants to merge 1 commit intohelm:masterfrom
aleerizw-zz:add-history-limit
Closed

Added --history-limit option.#135
aleerizw-zz wants to merge 1 commit intohelm:masterfrom
aleerizw-zz:add-history-limit

Conversation

@aleerizw-zz
Copy link
Copy Markdown

Old chart versions are deleted when a chart is added

Implements #134

Old chart versions are deleted when a chart is added
@davidovich
Copy link
Copy Markdown
Contributor

Thank you for this PR! I want to review it as we have similar needs! Will be looking at it tomorrow.

@aleerizw-zz
Copy link
Copy Markdown
Author

@davidovich Please let me know if there are any changes required. Thanks!

@jdolitsky
Copy link
Copy Markdown
Contributor

hi @aleerizw we will try to get this merged this week, thanks for your patience

@davidovich
Copy link
Copy Markdown
Contributor

@aleerizw sorry for the silence, work was keeping me very busy last week.

I am a bit uneasy on the point of adding a deletion process to an add operation (uploadChartPackage).

Could we envision starting a goroutine at server startup time that collects older charts and does the house keeping? We could trigger/control the house keeping in a channel from the uploadChartPackage function.

What do you think ?

@jdolitsky
Copy link
Copy Markdown
Contributor

We do need some sort of background task management in general.

@aleerizw-zz
Copy link
Copy Markdown
Author

I agree, I was not sure about this myself as well but wanted to get something out quickly :) I will make the changes

@aleerizw-zz aleerizw-zz deleted the add-history-limit branch August 21, 2018 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants