Merged
Conversation
48ecd5b to
60ad56a
Compare
Contributor
Author
|
I found a problem during implementing this feature , dose all of our storage impls support the same name file covering. With the #454 , we can now update our cache index in the chart updating case , but it still can be stored into backend storage if this backend storage do not support the same name file covering or add some other more suffixes into the package name . However, we maybe break the above case and the |
Contributor
Contributor
Author
Contributor
|
@scbizu can you rebase? |
…ption , impls #316 Signed-off-by: scnace <scbizu@gmail.com>
60ad56a to
84c9823
Compare
Contributor
Author
|
done @jdolitsky |
…hart-limit-option Signed-off-by: Josh Dolitsky <josh@dolit.ski>
jdolitsky
approved these changes
Jan 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
impls #316
Also , closes #376
Maybe in next release: