Conversation
This was referenced Sep 6, 2021
Contributor
scbizu
requested changes
Sep 30, 2021
Contributor
|
@jdolitsky Adds some review comments 👀 |
cbuto
approved these changes
Jan 21, 2022
Contributor
There was a problem hiding this comment.
lgtm (coming in cold 🥶). @jdolitsky @scbizu let me know if you want me to carry over the changes requested to a subsequent PR. I plan on removing any code using the EnforceSemver2 flag but still keeping the flag of course (if that's what we want to do) and then also make sure we return a 400 if the version is invalid (instead of a 500).
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
jdolitsky
force-pushed
the
v0.14.0-prep
branch
from
b462313 to
01b1309
Compare
Contributor
Author
|
@cbuto - thanks for taking a look. That would be great, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update Go dependencies, including Helm. Fixes #480 and #479
@scbizu - updating Helm version causes inability to parse invalid semver charts... should we deprecate the
--enforce-semver2since Helm doesnt support this anymore?