Do not fetch chart content, when not needed#504
Merged
Conversation
Signed-off-by: Niklas Walter <niklas.walter@volkswagen.de>
TwoStone
force-pushed
the
perf/reduce-chart-fetches-from-storage
branch
from
412c4bf to
de7a67d
Compare
jdolitsky
approved these changes
Jan 24, 2022
Contributor
|
@TwoStone - thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When creating the index.yaml for a repository the server fetches the content of the charts twice.
One time when fetching all charts from the storage backend, then determining the diff between cache and backend and then fetch the charts again.
This leads to slower index regeneration and higher costs for backend requests.
The metadata required for the determination of the objectSliceDiff should already be included in the ListObject response so we only have to read the whole file from the backend when it is changed.