Skip to content
This repository was archived by the owner on Feb 22, 2022. It is now read-only.

Comments

Add prometheus support to gitlab-ce#1186

Closed
simontesar wants to merge 1 commit intohelm:masterfrom
simontesar:gitlab-ce-prometheus
Closed

Add prometheus support to gitlab-ce#1186
simontesar wants to merge 1 commit intohelm:masterfrom
simontesar:gitlab-ce-prometheus

Conversation

@simontesar
Copy link
Contributor

@simontesar simontesar commented May 29, 2017

The integrated prometheus in Gitlab does currently not work with an RBAC enabled cluster and is also not considered in the charts service template.

This fixes #1191

@k8s-ci-robot
Copy link
Contributor

Hi @simt2. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with @k8s-bot ok to test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 29, 2017
@simontesar
Copy link
Contributor Author

Note: I actually signed the CLA and am still not sure why it shows up as not signed.

@kfox1111
Copy link
Collaborator

kfox1111 commented Jun 1, 2017

Can gitlab-ce use an external prometheus? There already is a prometheus chart and it might be easier to maintain then if it was reused?

@viglesiasce
Copy link
Contributor

Yes I agree with @kfox1111 that this should make a conditional dependency on the Prometheus chart and be able to point to an existing chart.

Please update with those changes.

Copy link
Contributor

@viglesiasce viglesiasce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should allow a configurable Prometheus URL and also allow deploying the prometheus chart rather than deploying its own Prometheus.

@mgoodness
Copy link
Contributor

Linking this to the discussion underway in #1138

@mgoodness
Copy link
Contributor

Closing this because it increasingly looks like we're going to deprecate our GitLab charts and point users to the "official" ones. I encourage you to submit this work there.

@mgoodness mgoodness closed this Aug 2, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Gitlab prometheus errors with RBAC enabled

5 participants