Skip to content
This repository was archived by the owner on Feb 22, 2022. It is now read-only.

mis-spelled the value for persistence#13249

Merged
k8s-ci-robot merged 1 commit intohelm:masterfrom
tompscanlan:update-ipfs-doc
May 24, 2019
Merged

mis-spelled the value for persistence#13249
k8s-ci-robot merged 1 commit intohelm:masterfrom
tompscanlan:update-ipfs-doc

Conversation

@tompscanlan
Copy link
Copy Markdown
Contributor

@tompscanlan tompscanlan commented Apr 24, 2019 •
edited
Loading

What this PR does / why we need it:

Correcting the doc for ipfs values.

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • [ x ] DCO signed
  • Chart Version bumped
  • [ x ] Variables are documented in the README.md

@helm-bot helm-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). labels Apr 24, 2019
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 24, 2019
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Apr 24, 2019

Hi @tompscanlan. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cpanato
Copy link
Copy Markdown
Member

cpanato commented May 23, 2019

@tompscanlan please bump the chart version and sign the DCO

@tompscanlan
mis-spelled the value for persistence
3307ef5 
* bump version
* fix spelling

Signed-off-by: Tom Scanlan <tscanlan@vmware.com>
@sameersbn
Copy link
Copy Markdown
Contributor

sameersbn commented May 24, 2019

/ok-to-test
/lgtm

@k8s-ci-robot k8s-ci-robot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 24, 2019
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented May 24, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sameersbn, tompscanlan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 24, 2019
@k8s-ci-robot k8s-ci-robot merged commit a73082d into helm:master May 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@cpanato cpanato Awaiting requested review from cpanato

@sameersbn sameersbn Awaiting requested review from sameersbn

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@tompscanlan @k8s-ci-robot @cpanato @sameersbn @helm-bot