Skip to content
This repository was archived by the owner on Feb 22, 2022. It is now read-only.

[stable/node-red]: add annotations in service.yaml#13674

Merged
k8s-ci-robot merged 6 commits intohelm:masterfrom
mscbpi:master
May 27, 2019
Merged

[stable/node-red]: add annotations in service.yaml#13674
k8s-ci-robot merged 6 commits intohelm:masterfrom
mscbpi:master

Conversation

@mscbpi
Copy link
Copy Markdown
Contributor

@mscbpi mscbpi commented May 10, 2019

What this PR does / why we need it:

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

Special notes for your reviewer:

Already documented but not effective in the code.

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md
  • title of the PR contains starts with chart name e.g. [stable/chart]

Signed-off-by: Martin Schlienger <ms@cbpi.ch>
@helm-bot helm-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 10, 2019
@k8s-ci-robot k8s-ci-robot requested review from billimek and maorfr May 10, 2019 08:53
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Hi @mscbpi. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 10, 2019
@mscbpi mscbpi changed the title node-red chart: add annotations in service.yaml [stable/node-red]: add annotations in service.yaml May 10, 2019
@billimek
Copy link
Copy Markdown
Collaborator

Hi @mscbpi,

Can you please do the following to move this PR along?

  1. sign the DCO via these instructions
  2. bump the chart version in Chart.yaml - I recommend using 1.2.2

Signed-off-by: Martin Schlienger <ms@cbpi.ch>

Signed-off-by: Martin Schlienger <ms@cbpi.ch>
@mscbpi mscbpi force-pushed the master branch 2 times, most recently from 01cdd31 to 0d9a29e Compare May 27, 2019 16:33
@helm-bot helm-bot added the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label May 27, 2019
mscbpi added 4 commits May 27, 2019 18:39
Signed-off-by: Martin Schlienger <ms@cbpi.ch>
Signed-off-by: Martin Schlienger <ms@cbpi.ch>
Signed-off-by: Martin Schlienger <ms@cbpi.ch>
@billimek
Copy link
Copy Markdown
Collaborator

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 27, 2019
@mscbpi
Copy link
Copy Markdown
Contributor Author

mscbpi commented May 27, 2019

Hi @mscbpi,

Can you please do the following to move this PR along?

  1. sign the DCO via these instructions
  2. bump the chart version in Chart.yaml - I recommend using 1.2.2

Hi, DCO is still complaining about past commit sign-off, tried to get the things ok but it seems it's still not ok... Thanks.

@billimek
Copy link
Copy Markdown
Collaborator

It looks good now!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 27, 2019
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: billimek, mscbpi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 27, 2019
@k8s-ci-robot k8s-ci-robot merged commit ebae557 into helm:master May 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants