[stable/node-red]: add annotations in service.yaml#13674
[stable/node-red]: add annotations in service.yaml#13674k8s-ci-robot merged 6 commits intohelm:masterfrom
Conversation
Signed-off-by: Martin Schlienger <ms@cbpi.ch>
|
Hi @mscbpi. Thanks for your PR. I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Hi @mscbpi, Can you please do the following to move this PR along?
|
Signed-off-by: Martin Schlienger <ms@cbpi.ch> Signed-off-by: Martin Schlienger <ms@cbpi.ch>
01cdd31 to
0d9a29e
Compare
Signed-off-by: Martin Schlienger <ms@cbpi.ch>
Signed-off-by: Martin Schlienger <ms@cbpi.ch>
Signed-off-by: Martin Schlienger <ms@cbpi.ch>
|
/ok-to-test |
Hi, DCO is still complaining about past commit sign-off, tried to get the things ok but it seems it's still not ok... Thanks. |
|
It looks good now! /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: billimek, mscbpi The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)Special notes for your reviewer:
Already documented but not effective in the code.
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[stable/chart]