This repository was archived by the owner on Feb 22, 2022. It is now read-only.
[stable/factorio] add apiVersion#13787
Merged
k8s-ci-robot merged 1 commit intohelm:masterfrom May 15, 2019
cpanato:GH-113763-factorio
Merged
[stable/factorio] add apiVersion#13787k8s-ci-robot merged 1 commit intohelm:masterfrom cpanato:GH-113763-factorio
k8s-ci-robot merged 1 commit intohelm:masterfrom
cpanato:GH-113763-factorio
Conversation
Signed-off-by: Carlos Panato <ctadeu@gmail.com>
helm-bot
added
the
Contribution Allowed
helm-bot
added
the
size/XS
k8s-ci-robot
added
the
approved
Member
Author
|
/assign @mattfarina |
mattfarina
reviewed
May 14, 2019
| apiVersion: v1 | ||
| name: factorio | ||
| version: 0.4.0 | ||
| version: 1.0.0 |
Contributor
There was a problem hiding this comment.
Shouldn't the version be 0.4.1?
Member
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, maorfr The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
goshlanguage
pushed a commit
to goshlanguage/charts
that referenced
this pull request
May 17, 2019
Signed-off-by: Carlos Panato <ctadeu@gmail.com>
eyenx
pushed a commit
to eyenx/charts
that referenced
this pull request
May 28, 2019
Signed-off-by: Carlos Panato <ctadeu@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding the
apiVersionforchart.yamlto fix the issue: #13763
Checklist
[stable/chart]