Skip to content
This repository was archived by the owner on Feb 22, 2022. It is now read-only.

[stable/mariadb] Add volume subPath for master#13990

Merged
k8s-ci-robot merged 2 commits intohelm:masterfrom
gouglhupf:mariadb-subpath
May 24, 2019
Merged

[stable/mariadb] Add volume subPath for master#13990
k8s-ci-robot merged 2 commits intohelm:masterfrom
gouglhupf:mariadb-subpath

Conversation

@gouglhupf
Copy link
Copy Markdown
Contributor

@gouglhupf gouglhupf commented May 20, 2019

What this PR does / why we need it:

Then specifying a existingClaim for the master it would be useful to be able to change the subPath within the existingClaim. This PR adds the option to add a subPath for the master's volume mount.

Which issue this PR fixes

To my knowledge there is no issue for this.

Special notes for your reviewer:

None

Checklist

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [stable/chart])

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 20, 2019
@k8s-ci-robot k8s-ci-robot requested review from juan131 and prydonius May 20, 2019 14:11
@helm-bot helm-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 20, 2019
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 20, 2019
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Hi @gouglhupf. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 20, 2019
@gouglhupf gouglhupf marked this pull request as ready for review May 20, 2019 14:27
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 20, 2019
Copy link
Copy Markdown
Collaborator

@tompizmor tompizmor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test
/lgtm

@k8s-ci-robot k8s-ci-robot added ok-to-test lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. lgtm Indicates that a PR is ready to be merged. labels May 23, 2019
@helm-bot helm-bot removed the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label May 23, 2019
gouglhupf added 2 commits May 23, 2019 14:43
Signed-off-by: gouglhupf <dr.gouglhupf@gmail.com>
Signed-off-by: gouglhupf <dr.gouglhupf@gmail.com>
@helm-bot helm-bot added the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label May 23, 2019
@tompizmor
Copy link
Copy Markdown
Collaborator

/retest

@tompizmor
Copy link
Copy Markdown
Collaborator

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 24, 2019
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gouglhupf, tompizmor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 61895ae into helm:master May 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants