Skip to content
This repository was archived by the owner on Feb 22, 2022. It is now read-only.

[stable/postgresql] Allow changing port for postgresql chart#14112

Merged
k8s-ci-robot merged 1 commit intohelm:masterfrom
tompizmor:allow_postgresql_port_change
May 24, 2019
Merged

[stable/postgresql] Allow changing port for postgresql chart#14112
k8s-ci-robot merged 1 commit intohelm:masterfrom
tompizmor:allow_postgresql_port_change

Conversation

@tompizmor
Copy link
Copy Markdown
Collaborator

@tompizmor tompizmor commented May 24, 2019

Signed-off-by: tompizmor tompizmor@gmail.com

What this PR does / why we need it:

Right now if you set service.port to a value other than 5432, the PostgreSQL chart won't work.

Which issue this PR fixes

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Title of the PR starts with chart name (e.g. [stable/chart])

Signed-off-by: tompizmor <tompizmor@gmail.com>
@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 24, 2019
@k8s-ci-robot k8s-ci-robot requested review from carrodher and juan131 May 24, 2019 07:33
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 24, 2019
Copy link
Copy Markdown
Collaborator

@juan131 juan131 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test
/lgtm

@k8s-ci-robot k8s-ci-robot added ok-to-test lgtm Indicates that a PR is ready to be merged. labels May 24, 2019
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: juan131, tompizmor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit b283409 into helm:master May 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[stable/postgresql] Using non 5432 service.port will not work

4 participants