Skip to content
This repository was archived by the owner on Feb 22, 2022. It is now read-only.

[stable/kong] Add proxy.externalTrafficPolicy to the configuration#14123

Merged
k8s-ci-robot merged 2 commits intohelm:masterfrom
Ngob:feature/externalTrafficPolicy
May 25, 2019
Merged

[stable/kong] Add proxy.externalTrafficPolicy to the configuration#14123
k8s-ci-robot merged 2 commits intohelm:masterfrom
Ngob:feature/externalTrafficPolicy

Conversation

@Ngob
Copy link
Copy Markdown
Contributor

@Ngob Ngob commented May 24, 2019

Add proxy.externalTrafficPolicy to the configuration to allow configuring externalTrafficPolicy on kong-proxy SVC

Signed-off-by: Benoît Ngô ngobenoit@gmail.com

What this PR does / why we need it:

This PR add the configuration proxy.externalTrafficPolicy to allow configuring externalTrafficPolicy on kong-proxy SVC.

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • [ X ] DCO signed
  • [ X ] Chart Version bumped
  • [ X ] Variables are documented in the README.md
  • [ X ] Title of the PR starts with chart name (e.g. [stable/chart])

@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 24, 2019
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 24, 2019
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Hi @Ngob. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Ngob added 2 commits May 24, 2019 15:15
…ring externalTrafficPolicy on kong-proxy SVC

Signed-off-by: Benoît Ngô <ngobenoit@gmail.com>
Signed-off-by: Benoît Ngô <ngobenoit@gmail.com>
@Ngob Ngob force-pushed the feature/externalTrafficPolicy branch from b35e692 to e687dd4 Compare May 24, 2019 13:17
@hbagdi
Copy link
Copy Markdown
Collaborator

hbagdi commented May 25, 2019

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 25, 2019
@hbagdi
Copy link
Copy Markdown
Collaborator

hbagdi commented May 25, 2019

/lgtm

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hbagdi, Ngob

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 25, 2019
@k8s-ci-robot k8s-ci-robot merged commit 5c5d7ed into helm:master May 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants