Skip to content
This repository was archived by the owner on Feb 22, 2022. It is now read-only.

[stable/nexcloud] Multiple config.php file#15212

Merged
k8s-ci-robot merged 1 commit intohelm:masterfrom
cthiebault:nextcloud-extra-config
Jul 8, 2019
Merged

[stable/nexcloud] Multiple config.php file#15212
k8s-ci-robot merged 1 commit intohelm:masterfrom
cthiebault:nextcloud-extra-config

Conversation

@cthiebault
Copy link
Copy Markdown
Contributor

@cthiebault cthiebault commented Jul 2, 2019

What this PR does / why we need it:

Nextcloud supports loading configuration parameters from multiple files. You can add arbitrary files ending with .config.php in the config/ directory.

Use ConfigMap & volumeMounts to create extra config file in /var/www/html/config

Checklist

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [stable/chart])

Use `ConfigMap` & `volumeMounts` to create extra config file in `/var/www/html/config`

Signed-off-by: Cedric Thiebault <cedric.thiebault@gmail.com>
@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 2, 2019
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Hi @cthiebault. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 2, 2019
@billimek
Copy link
Copy Markdown
Collaborator

billimek commented Jul 3, 2019

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 3, 2019
@billimek
Copy link
Copy Markdown
Collaborator

billimek commented Jul 8, 2019

/lgtm

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: billimek, cthiebault

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 8, 2019
@k8s-ci-robot k8s-ci-robot merged commit c7ac02b into helm:master Jul 8, 2019
ThoTischner pushed a commit to bitsbeats/charts that referenced this pull request Aug 13, 2019
Use `ConfigMap` & `volumeMounts` to create extra config file in `/var/www/html/config`

Signed-off-by: Cedric Thiebault <cedric.thiebault@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants