This repository was archived by the owner on Feb 22, 2022. It is now read-only.
[stable/prometheus-operator] Add 10m timeout, don't clean up to delete hooks#17090
Closed
vsliouniaev wants to merge 2 commits intohelm:masterfrom
Closed
[stable/prometheus-operator] Add 10m timeout, don't clean up to delete hooks#17090vsliouniaev wants to merge 2 commits intohelm:masterfrom
vsliouniaev wants to merge 2 commits intohelm:masterfrom
Conversation
Signed-off-by: vas <vasily.sliouniaev@jet.com>
helm-bot
added
Contribution Allowed
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vsliouniaev The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
This was referenced Sep 12, 2019
[stable/prometheus-operator] Release "prometheus-operator" failed: rpc error: code = Canceled
#15977
Closed
Signed-off-by: vas <vasily.sliouniaev@jet.com>
vsliouniaev
changed the title
Collaborator
Author
|
Looks like this does not help. Closing the PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Some clusters seem to be very slow at handling deletes. Increasing the timeout to a very high value should be perfectly fine
Which issue this PR fixes
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[stable/chart])