Skip to content
This repository was archived by the owner on Feb 22, 2022. It is now read-only.

[stable/couchdb]: Add optional networkpolicy#17262

Closed
willholley wants to merge 1 commit intohelm:masterfrom
willholley:couchdb_networkpolicy
Closed

[stable/couchdb]: Add optional networkpolicy#17262
willholley wants to merge 1 commit intohelm:masterfrom
willholley:couchdb_networkpolicy

Conversation

@willholley
Copy link
Copy Markdown
Contributor

@willholley willholley commented Sep 19, 2019 •
edited
Loading

What this PR does / why we need it:

Adds a NetworkPolicy to enable communication between CouchDB pods and external ingress on port 5984. This is required in environments (e.g. Red Hat OpenShift) which apply DenyAll network policies by default.

cc @kocolosk

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

@helm-bot helm-bot added the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label Sep 19, 2019
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Sep 19, 2019

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: willholley
To complete the pull request process, please assign prydonius
You can assign the PR to them by writing /assign @prydonius in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@helm-bot helm-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 19, 2019
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Sep 19, 2019

Hi @willholley. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 19, 2019
@willholley
[stable/couchdb]: Add optional networkpolicy
9ef11e0 
Adds a NetworkPolicy to enable communication between CouchDB pods
and external ingress on port 5984. This is required in environments
(e.g. Red Hat OpenShift) which apply DenyAll network policies
by default.

Signed-off-by: Will Holley <willholley@apache.org>
@willholley willholley force-pushed the couchdb_networkpolicy branch from 263dae0 to 9ef11e0 Compare September 19, 2019 19:23
kocolosk
kocolosk approved these changes Sep 19, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@kocolosk kocolosk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 nice work

@stale
Copy link
Copy Markdown

stale bot commented Oct 19, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions.

@stale stale bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 19, 2019
@zanhsieh
Copy link
Copy Markdown
Collaborator

zanhsieh commented Oct 20, 2019

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 20, 2019
@stale stale bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 20, 2019
@willholley
Copy link
Copy Markdown
Contributor Author

willholley commented Oct 21, 2019

in light of #18079 I'll migrate this PR to the new chart at https://github.com/apache/couchdb-helm

@willholley willholley closed this Oct 21, 2019
willholley added a commit to apache/couchdb-helm that referenced this pull request Oct 22, 2019
@willholley
Add support for pod annotations
1a84cb2 
Ported from helm/charts#17262.

Thanks to @Pinpin31.
willholley added a commit to apache/couchdb-helm that referenced this pull request Oct 22, 2019
@willholley
Add optional network policy
dfd8f3c 
Adds a NetworkPolicy to enable communication between CouchDB pods
and external ingress on port 5984.

This is required in environments (e.g. Red Hat OpenShift) which apply
DenyAll network policies by default.

ported from helm/charts#17262
willholley added a commit to apache/couchdb-helm that referenced this pull request Oct 28, 2019
@willholley
Add support for pod annotations
e3de61f 
Ported from helm/charts#17262.

Thanks to @Pinpin31.
willholley added a commit to apache/couchdb-helm that referenced this pull request Oct 28, 2019
@willholley
Add optional network policy
bfa842e 
Adds a NetworkPolicy to enable communication between CouchDB pods
and external ingress on port 5984.

This is required in environments (e.g. Red Hat OpenShift) which apply
DenyAll network policies by default.

ported from helm/charts#17262
willholley added a commit to apache/couchdb-helm that referenced this pull request Oct 31, 2019
@willholley
Add optional network policy
1960abf 
Adds a NetworkPolicy to enable communication between CouchDB pods
and external ingress on port 5984.

This is required in environments (e.g. Red Hat OpenShift) which apply
DenyAll network policies by default.

ported from helm/charts#17262
willholley added a commit to apache/couchdb-helm that referenced this pull request Oct 31, 2019
@willholley
Add optional network policy
7bb596a 
Adds a NetworkPolicy to enable communication between CouchDB pods
and external ingress on port 5984.

This is required in environments (e.g. Red Hat OpenShift) which apply
DenyAll network policies by default.

ported from helm/charts#17262
willholley added a commit to apache/couchdb-helm that referenced this pull request Oct 31, 2019
@willholley
Add optional network policy
c21141e 
Adds a NetworkPolicy to enable communication between CouchDB pods
and external ingress on port 5984.

This is required in environments (e.g. Red Hat OpenShift) which apply
DenyAll network policies by default.

ported from helm/charts#17262
willholley added a commit to apache/couchdb-helm that referenced this pull request Oct 31, 2019
@willholley
Add optional network policy
6ca32c7 
Adds a NetworkPolicy to enable communication between CouchDB pods
and external ingress on port 5984.

This is required in environments (e.g. Red Hat OpenShift) which apply
DenyAll network policies by default.

ported from helm/charts#17262
willholley added a commit to apache/couchdb-helm that referenced this pull request Oct 31, 2019
@willholley
Add optional network policy
17b3889 
Adds a NetworkPolicy to enable communication between CouchDB pods
and external ingress on port 5984.

This is required in environments (e.g. Red Hat OpenShift) which apply
DenyAll network policies by default.

ported from helm/charts#17262
@willholley willholley deleted the couchdb_networkpolicy branch November 5, 2019 08:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@mattfarina mattfarina Awaiting requested review from mattfarina

@sameersbn sameersbn Awaiting requested review from sameersbn

1 more reviewer

@kocolosk kocolosk kocolosk approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). ok-to-test size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@willholley @k8s-ci-robot @zanhsieh @kocolosk @helm-bot