Skip to content
This repository was archived by the owner on Feb 22, 2022. It is now read-only.

[incubator/druid] Add securityContext and fix local storage mounting path#23561

Merged
k8s-ci-robot merged 3 commits intohelm:masterfrom
AWaterColorPen:users/slyao/druid
Sep 29, 2020
Merged

[incubator/druid] Add securityContext and fix local storage mounting path#23561
k8s-ci-robot merged 3 commits intohelm:masterfrom
AWaterColorPen:users/slyao/druid

Conversation

@AWaterColorPen
Copy link
Collaborator

@AWaterColorPen AWaterColorPen commented Aug 18, 2020

Is this a new chart

NOTE: We're experiencing a high volume of PRs to this repo and reviews will be delayed. Please host your own chart repository and submit your repository to the Helm Hub instead of this repo to make them discoverable to the community. Here is how to submit new chart repositories to the Helm Hub.

What this PR does / why we need it:

  • add securityContext to Historical and MiddleManager statefulSet
  • set default securityContext.fsGroup=1000 in values.yaml, which is the default id of the druid container user druid.
  • change Historical and MiddleManager node's mount volume path from /var/druid/ to /opt/druid/var/druid/, which is the default path to store stateful files.

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

Special notes for your reviewer:

base on #23069 and #23121 PRs, but they blocked.

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [stable/mychartname])

Signed-off-by: AWaterColorPen <hellis@foxmail.com>
Signed-off-by: AWaterColorPen <hellis@foxmail.com>
@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 18, 2020
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 18, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @AWaterColorPen. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 18, 2020
@AWaterColorPen AWaterColorPen changed the title [incubator/druid] Add securityContext and fix local storage mounting path and Add [incubator/druid] Add securityContext and fix local storage mounting path Aug 18, 2020
@AWaterColorPen
Copy link
Collaborator Author

AWaterColorPen commented Aug 19, 2020

/assign @maver1ck
please help for a review

@AWaterColorPen
Copy link
Collaborator Author

@sameersbn
could you help for a /ok-to-test

@maver1ck
Copy link
Collaborator

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 13, 2020
Signed-off-by: AWaterColorPen <hellis@foxmail.com>
@AWaterColorPen
Copy link
Collaborator Author

/lgtm

@k8s-ci-robot
Copy link
Contributor

@AWaterColorPen: you cannot LGTM your own PR.

Details

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@AWaterColorPen
Copy link
Collaborator Author

@maver1ck could you help for a /lgtm

@maver1ck
Copy link
Collaborator

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 29, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AWaterColorPen, maver1ck

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[incubator/druid] fails with containerd 1.12.3 -- mkdir: can't create directory 'var/[tmp,druid]': Permission denied

4 participants