This repository was archived by the owner on Feb 22, 2022. It is now read-only.
Deprecate dask-distributed chart#4083
Merged
k8s-ci-robot merged 5 commits intohelm:masterfrom Mar 10, 2018
Merged
Conversation
k8s-ci-robot
added
cncf-cla: yes
mrocklin
force-pushed
the
deprecate-dask-distributed
branch
from
337b5bd to
16961e2
Compare
unguiculus
suggested changes
Mar 9, 2018
| icon: https://avatars3.githubusercontent.com/u/17131925?v=3&s=200 | ||
| sources: | ||
| - https://github.com/dask/distributed | ||
| maintainers: |
Member
There was a problem hiding this comment.
Remove maintainers and bump version.
See https://github.com/kubernetes/charts/blob/master/PROCESSES.md#deprecating-a-chart
Member
|
/assign |
Contributor
Author
|
Referencing #2914 (comment) where @danielfrg gave consent to deprecate this chart |
unguiculus
reviewed
Mar 10, 2018
| # For details on deprecation, including how to un-deprecate a chart, | ||
| # see the PROCESSES.md file. | ||
| deprecated: true | ||
| version: 3.0.0 |
Contributor
Author
|
Changed to 2.0.1
…On Sat, Mar 10, 2018 at 5:15 AM, Reinhard Nägele ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In stable/dask-distributed/Chart.yaml
<#4083 (comment)>:
> @@ -1,10 +1,11 @@
name: dask-distributed
-version: 2.0.0
-description: Distributed computation in Python
+# The dask-distributed chart is deprecated and no longer maintained.
+# For details on deprecation, including how to un-deprecate a chart,
+# see the PROCESSES.md file.
+deprecated: true
+version: 3.0.0
Why not 2.0.1?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#4083 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AASszDOEZ1cFQlSJog0Tfb3Mj4MzOlhHks5tc6epgaJpZM4Skqgj>
.
|
unguiculus
suggested changes
Mar 10, 2018
| @@ -1,3 +1,7 @@ | |||
| ########################################################## | |||
| # This chart has been deprecated in favor of stable/dask # | |||
| ########################################################## | |||
Contributor
Author
There was a problem hiding this comment.
Whoops! My apologies for missing this. Resolved.
Member
|
/ok-to-test |
k8s-ci-robot
removed
the
needs-ok-to-test
Member
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mrocklin, unguiculus The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
ichtar
pushed a commit
to Bestmile/charts
that referenced
this pull request
May 15, 2018
* Deprecate dask-distributed chart * remove maintainers * update chart.yaml * use version 2.0.1 rather than 3.0.0 * move deprecation warning from dask to dask-distributed
voron
pushed a commit
to dysnix/helm-charts
that referenced
this pull request
Sep 5, 2018
* Deprecate dask-distributed chart * remove maintainers * update chart.yaml * use version 2.0.1 rather than 3.0.0 * move deprecation warning from dask to dask-distributed Signed-off-by: voron <av@arilot.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following on #2914 , this deprecates the old dask-distributed chart