Skip to content
This repository was archived by the owner on Feb 22, 2022. It is now read-only.

Comments

[stable/kube-lego] Update link to migration guide#5371

Merged
k8s-ci-robot merged 4 commits intohelm:masterfrom
rolandboon:patch-1
May 9, 2018
Merged

[stable/kube-lego] Update link to migration guide#5371
k8s-ci-robot merged 4 commits intohelm:masterfrom
rolandboon:patch-1

Conversation

@rolandboon
Copy link
Contributor

What this PR does / why we need it:
The docs of cert-manager are moved from the repo to readthedocs.io. The current link to migration guide in readme is dead.

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 3, 2018
@rolandboon
Copy link
Contributor Author

/assign @prydonius

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels May 3, 2018
Copy link
Contributor

@timstoop timstoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Charts are immutable, so all changes, even documentation changes, require a bump of the version in Chart.yaml. Simply increase the patch level by 1.

@prydonius
Copy link
Member

prydonius commented May 4, 2018

@rolandboon the CI requires a home and apiVersion field be added to the Chart.yaml. Even though this chart is deprecated, the migration guide is an important link that we should update. We can try adding the home and apiVersion here, if there are further issues that aren't an easy fix, we may consider bypassing CI.

@unguiculus
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 9, 2018
@unguiculus
Copy link
Member

/assign

@unguiculus
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 9, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rolandboon, unguiculus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 9, 2018
@k8s-ci-robot k8s-ci-robot merged commit 4aa1ef0 into helm:master May 9, 2018
ichtar pushed a commit to Bestmile/charts that referenced this pull request May 15, 2018
* [stable/kube-lego] Update link to migration guide

* [stable/kube-lego] Bump chart version

* [stable/kube-lego] Add home key to Chart

* [kube-lego] Add appVersion to Chart
or1can pushed a commit to or1can/charts that referenced this pull request Jul 10, 2018
* [stable/kube-lego] Update link to migration guide

* [stable/kube-lego] Bump chart version

* [stable/kube-lego] Add home key to Chart

* [kube-lego] Add appVersion to Chart
voron pushed a commit to dysnix/helm-charts that referenced this pull request Sep 5, 2018
* [stable/kube-lego] Update link to migration guide

* [stable/kube-lego] Bump chart version

* [stable/kube-lego] Add home key to Chart

* [kube-lego] Add appVersion to Chart

Signed-off-by: voron <av@arilot.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants