Cerebro service annotations, image update and configuration overrides#6595
Cerebro service annotations, image update and configuration overrides#6595k8s-ci-robot merged 5 commits intohelm:masterfrom
Conversation
|
/assign @prydonius |
stable/cerebro/Chart.yaml
Outdated
There was a problem hiding this comment.
I tried to explain in the PR comment. See e.g. 0dd516d#diff-0fcab9ba30f2d528e9326bf1299ef520R9
There was a problem hiding this comment.
Basically wanted to make sure every commit (~ version) introduced by this PR has a correct Chart version attached to it.
|
LGTM Running it right now without issue, I was about to write it myself. Good timing, thanks. |
stable/cerebro/Chart.yaml
Outdated
There was a problem hiding this comment.
this should probably be removed if using another image
There was a problem hiding this comment.
Good point, will do (also in README).
With this PR, one can configure Cerebro through Helm *values*, which is primarily useful to add predefined Elasticsearch clusters (`hosts`). Setting `auth` options is currently not supported. Also, the Cerebro database file is kept in an `emptyDir` instead of storing it inside the container. Note: the `secret` value is changed at every (re)deployment, which may impact cookies and CSRF tokens validated by Cerebro.
|
Updated to use the 'new' Docker image source repository in |
|
/ok-to-test |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: NicolasT, unguiculus The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
See: 0111ba4 See: helm@0111ba4 See: helm#6595 See: helm#6595
Some recent changes in the Cerebro chart allow to configure the application, e.g. to set a pre-configured Elasticsearch cluster. See: helm/charts#6595 See: helm/charts@0111ba4
Some recent changes in the Cerebro chart allow to configure the application, e.g. to set a pre-configured Elasticsearch cluster. See: helm/charts#6595 See: helm/charts@0111ba4
Some recent changes in the Cerebro chart allow to configure the application, e.g. to set a pre-configured Elasticsearch cluster. See: helm/charts#6595 See: helm/charts@0111ba4
…helm#6595) * stable/cerebro: Add service annotations support * stable/cerebro: Use 'official' Docker image Use https://hub.docker.com/r/lmenezes/cerebro/ instead of https://hub.docker.com/r/yannart/cerebro/ * stable/cerebro: Set application config through values With this PR, one can configure Cerebro through Helm *values*, which is primarily useful to add predefined Elasticsearch clusters (`hosts`). Setting `auth` options is currently not supported. Also, the Cerebro database file is kept in an `emptyDir` instead of storing it inside the container. Note: the `secret` value is changed at every (re)deployment, which may impact cookies and CSRF tokens validated by Cerebro. * Update values.yaml * Update Chart.yaml
See: 0111ba4 See: helm@0111ba4 See: helm#6595 See: helm#6595
See: 0111ba4 See: helm@0111ba4 See: helm#6595 See: helm#6595 Signed-off-by: aba182 <ajwilhel@gmail.com>
|
Hello! I might have found a little typo in the helm chart. Here the command: The resulting K8s config manifest: https://github.com/helm/charts/blob/master/stable/cerebro/templates/configmap.yaml#L31 This one should be after the item, only if there is multiple hosts, I guess? Thx |
…helm#6595) * stable/cerebro: Add service annotations support * stable/cerebro: Use 'official' Docker image Use https://hub.docker.com/r/lmenezes/cerebro/ instead of https://hub.docker.com/r/yannart/cerebro/ * stable/cerebro: Set application config through values With this PR, one can configure Cerebro through Helm *values*, which is primarily useful to add predefined Elasticsearch clusters (`hosts`). Setting `auth` options is currently not supported. Also, the Cerebro database file is kept in an `emptyDir` instead of storing it inside the container. Note: the `secret` value is changed at every (re)deployment, which may impact cookies and CSRF tokens validated by Cerebro. * Update values.yaml * Update Chart.yaml Signed-off-by: Jakob Niggel <info@jakobniggel.de>
See: 0111ba4 See: helm@0111ba4 See: helm#6595 See: helm#6595 Signed-off-by: Jakob Niggel <info@jakobniggel.de>
…helm#6595) * stable/cerebro: Add service annotations support * stable/cerebro: Use 'official' Docker image Use https://hub.docker.com/r/lmenezes/cerebro/ instead of https://hub.docker.com/r/yannart/cerebro/ * stable/cerebro: Set application config through values With this PR, one can configure Cerebro through Helm *values*, which is primarily useful to add predefined Elasticsearch clusters (`hosts`). Setting `auth` options is currently not supported. Also, the Cerebro database file is kept in an `emptyDir` instead of storing it inside the container. Note: the `secret` value is changed at every (re)deployment, which may impact cookies and CSRF tokens validated by Cerebro. * Update values.yaml * Update Chart.yaml
See: 0111ba4 See: helm@0111ba4 See: helm#6595 See: helm#6595
This PR updates the
stable/cerebrochart toemptyDir) for the application databaseNote to reviewers:
initContainer0.1.1->0.2.0->0.2.1->0.3.0